From: Wolfram Sang <wsa@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: i801: I2C block read should be usable also on ICH/ICH0/ICH2/ICH3/ICH4
Date: Sun, 17 Apr 2022 04:27:33 +0200 [thread overview]
Message-ID: <Ylt7FU/3TTvvcNx7@shikoro> (raw)
In-Reply-To: <b4cb50db-7226-282f-e04a-02fbe0b605a0@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]
On Mon, Dec 06, 2021 at 10:18:49PM +0100, Heiner Kallweit wrote:
> Currently we use the following feature definitions. However, according to
> the respective datasheets, also ICH/ICH0/ICH2/ICH3/ICH4 support I2C block
> read. The implementation we have should work also on these chip versions.
>
> The commit message of 6342064cad7a ("i2c-i801: Implement I2C block read
> support") states that i2c block read is supported from ICH5 only.
> This doesn't seem to be true. Or is this feature broken on older chip
> versions?
>
> To me it seems we could remove FEATURE_I2C_BLOCK_READ because all chip
> versions support this feature. Below is an experimental patch, for the
> ones with test hw. A test case could be to use decode-dimms that
> uses i2c block read to read the EEPROM content.
>
> * Supports the following Intel I/O Controller Hubs (ICH):
> *
> * I/O Block I2C
> * region SMBus Block proc. block
> * Chip name PCI ID size PEC buffer call read
> * ---------------------------------------------------------------------------
> * 82801AA (ICH) 0x2413 16 no no no no
> * 82801AB (ICH0) 0x2423 16 no no no no
> * 82801BA (ICH2) 0x2443 16 no no no no
> * 82801CA (ICH3) 0x2483 32 soft no no no
> * 82801DB (ICH4) 0x24c3 32 hard yes no no
> * 82801E (ICH5) 0x24d3 32 hard yes yes yes
Any reason you skipped this patch in your latest series?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-04-17 2:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 21:18 i801: I2C block read should be usable also on ICH/ICH0/ICH2/ICH3/ICH4 Heiner Kallweit
2021-12-11 23:22 ` Heiner Kallweit
2022-04-17 2:27 ` Wolfram Sang [this message]
2022-04-17 9:09 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ylt7FU/3TTvvcNx7@shikoro \
--to=wsa@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox