From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: rcar: call pm_runtime_put() only if it has ID_P_PM_BLOCKED
Date: Fri, 20 May 2022 11:44:00 +0200 [thread overview]
Message-ID: <Yodi4D0p+XXF0uGu@shikoro> (raw)
In-Reply-To: <874k2wtqgp.wl-kuninori.morimoto.gx@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
Hi Morimoto-san,
> ID_P_PM_BLOCKED is controlling PM status.
> We need to check it for pm_runtime_put() on rcar_i2c_probe(),
> otherwise it will be duplicated put.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Yes, you found a problem here, thank you! However, the solution is not
complete and while investigating what else is needed, I already created
V2 myself. I hope you don't mind. I will send it in a minute.
All the best,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-05-20 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 1:15 [PATCH] i2c: rcar: call pm_runtime_put() only if it has ID_P_PM_BLOCKED Kuninori Morimoto
2022-05-20 9:44 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yodi4D0p+XXF0uGu@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-i2c@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox