From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CF5FC43334 for ; Tue, 12 Jul 2022 11:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232467AbiGLLcg (ORCPT ); Tue, 12 Jul 2022 07:32:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232347AbiGLLc3 (ORCPT ); Tue, 12 Jul 2022 07:32:29 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68F9BAC061 for ; Tue, 12 Jul 2022 04:32:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 07057B81818 for ; Tue, 12 Jul 2022 11:32:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3026C3411C; Tue, 12 Jul 2022 11:32:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657625543; bh=GHAm+j5Y07u6pJDEuCNgpzC1OGh6fvPUkchPQ8iDirI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pOPthHhmQuRxSgY9/4rOz7sSLlUKnR1eTDlXTkCYkhV2XwENwf2IwYc4JJCFKWTUW ZwrELsWzmuALt9uvkC+eUyVy3QAo3dNzuXASGIo76zpjKAX7skpTLlPB4698yNYUu/ tRRb7FtV9zcno3iiODxcwaw4s76j24tszGYAjTJYR8b+S0CKwLVFkXHBNI2OG1gPVA xwGOsaTBX507I06nbIYURG9eEbfpGJNjtywqKbx6nuCodnULXOZB6hdMnDZnYaKZ67 CbwvUVeh3traywWxjM8QfzCQtglkGi553Q3nMk/hEaSZfB0l1tAix2lvIo4g7koJ6a NcckOkYZr/tVA== Date: Tue, 12 Jul 2022 13:32:19 +0200 From: Wolfram Sang To: Marco Felsch Cc: Francesco Dolcini , Oleksij Rempel , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Oleksandr Suvorov , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1] i2c: imx: Retry transfer on transient failure Message-ID: Mail-Followup-To: Wolfram Sang , Marco Felsch , Francesco Dolcini , Oleksij Rempel , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Oleksandr Suvorov , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220712082415.319738-1-francesco.dolcini@toradex.com> <20220712084716.bw626gt7cwcjt3wq@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fnKsbM3qvd+SFm6d" Content-Disposition: inline In-Reply-To: <20220712084716.bw626gt7cwcjt3wq@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org --fnKsbM3qvd+SFm6d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > +#define I2C_IMX_MAX_RETRIES 3 /* Retries on arbitration loss */ >=20 > Just one question: Why 3 and should we document this within the commit > message? Note that you can always change this from userspace via i2c-dev and the I2C_RETRIES ioctl. So, it is really about a default value here. --fnKsbM3qvd+SFm6d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmLNW78ACgkQFA3kzBSg KbbUdQ/8CAU//JNvPDVQt7O7ZYGlgZmg7jGsegx2SuDKzc9myrBUnznSvyjgV+Lj ulgpD1gXN+FykSx+O4Fi5KukmSGgSRAheG/RsJDEKJWKSkWRIfnQI7RhARFAh/4a eOFLzCJC1kUrcG98n6QBFU2NKLtijPrPPAj9Tj9VCUuUT7QYTQBULeYLNo8+tVO6 wS43/D+Ofz4rxG2j/t7IK7pQC68FoFfYJJ3TjY0srLeP3CzPv7NfJR5JfFAWauhg nYomYj1vSW+mSED+T0WRyi4dfmu1u0VANmXwm6GEsq/qgASjyxLpbMfX6m84bwwx 4Gde1TasFFxzKvrKtS2GN/xMeNt45df7Td91/cd9I8n1deHDneSX9Rsr6oyG9Bmq sMyWoY5UvOihoxmAorhG2SoSH8WKgmTn86xFImm7WTi0icpCCIzoGoaLtOPMKCiJ ZSNKzE2FuIoEA0+qRWJkQCJkMzzdeLoegx5AFmtEyCc6uvCKPaN459it84z5/KJ4 ajmj52VOay/+ACoiFSAB3mE2B8Y1uqJv4nk0tu3aWSqBhDjzE9thNgfezZnfMxlE Nuy04GIHFoQ/kSMhSmeii06Cg0Oajyp7VS7PINXJNvwogXAw18T5f4TmPlyYpMai JS6/pWKW+OE7pto0+kDEF9IERj4CxS2KgObMl2VzDWR7hPZQtC8= =JVD0 -----END PGP SIGNATURE----- --fnKsbM3qvd+SFm6d--