From: Wolfram Sang <wsa@kernel.org>
To: Conor.Dooley@microchip.com
Cc: linux-i2c@vger.kernel.org, ben.dooks@codethink.co.uk,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
Daire.McNamara@microchip.com
Subject: Re: [PATCH v6 1/2] i2c: add support for microchip fpga i2c controllers
Date: Wed, 6 Jul 2022 12:32:48 +0200 [thread overview]
Message-ID: <YsVk0Gg1x7juHcZU@shikoro> (raw)
In-Reply-To: <ac070176-93b9-3bc4-5589-ec57d4d38af4@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
> I'd prefer the latter. Being called "core" is unfortunate and I
> did think about that. i2c-microchip-corei2c would have been my
> first choice but I thought the double usage of i2c would've been
> disapproved of haha
:) Well, double "i2c" is not exactly pretty but since it is the name of
that IP core...
> >> + if (idev->msg_len <= 0)
> >> + finished = true;
> >
> > How can it happen that len is < 0? Wouldn't that be an error case?
Is it to be on the safe side?
> > Have you testes SMBUS_QUICK as well?
>
> Not specifically SMBUS_QUICK, but I did test with hardware
> that uses "zero-length" messages.
Good!
> Thanks for the review :)
You are welcome.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-07-06 10:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 7:42 [PATCH v6 1/2] i2c: add support for microchip fpga i2c controllers Conor Dooley
2022-06-21 7:42 ` [PATCH v6 2/2] MAINTAINERS: add the polarfire soc's i2c driver Conor Dooley
2022-07-06 7:21 ` Wolfram Sang
2022-07-06 7:41 ` Conor.Dooley
2022-07-06 7:19 ` [PATCH v6 1/2] i2c: add support for microchip fpga i2c controllers Wolfram Sang
2022-07-06 8:03 ` Conor.Dooley
2022-07-06 10:32 ` Wolfram Sang [this message]
2022-07-06 10:50 ` Conor.Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsVk0Gg1x7juHcZU@shikoro \
--to=wsa@kernel.org \
--cc=Conor.Dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox