* [PATCH v1 1/1] i2c: scmi: Replace open coded acpi_match_device() @ 2022-06-30 19:55 Andy Shevchenko 2022-07-01 11:51 ` Andy Shevchenko 0 siblings, 1 reply; 4+ messages in thread From: Andy Shevchenko @ 2022-06-30 19:55 UTC (permalink / raw) To: Andy Shevchenko, linux-i2c, linux-kernel; +Cc: Wolfram Sang Replace open coded acpi_match_device() in acpi_smbus_cmi_add(). Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/i2c/busses/i2c-scmi.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-scmi.c b/drivers/i2c/busses/i2c-scmi.c index 6746aa46d96c..ba20f6c60e06 100644 --- a/drivers/i2c/busses/i2c-scmi.c +++ b/drivers/i2c/busses/i2c-scmi.c @@ -376,10 +376,9 @@ static int acpi_smbus_cmi_add(struct acpi_device *device) smbus_cmi->cap_read = 0; smbus_cmi->cap_write = 0; - for (id = acpi_smbus_cmi_ids; id->id[0]; id++) - if (!strcmp(id->id, acpi_device_hid(device))) - smbus_cmi->methods = - (struct smbus_methods_t *) id->driver_data; + id = acpi_match_device(device, acpi_smbus_cmi_ids); + if (id) + smbus_cmi->methods = (struct smbus_methods_t *)id->driver_data; acpi_walk_namespace(ACPI_TYPE_METHOD, smbus_cmi->handle, 1, acpi_smbus_cmi_query_methods, NULL, smbus_cmi, NULL); -- 2.35.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] i2c: scmi: Replace open coded acpi_match_device() 2022-06-30 19:55 [PATCH v1 1/1] i2c: scmi: Replace open coded acpi_match_device() Andy Shevchenko @ 2022-07-01 11:51 ` Andy Shevchenko 2022-07-06 19:32 ` Wolfram Sang 0 siblings, 1 reply; 4+ messages in thread From: Andy Shevchenko @ 2022-07-01 11:51 UTC (permalink / raw) To: linux-i2c, linux-kernel; +Cc: Wolfram Sang On Thu, Jun 30, 2022 at 10:55:41PM +0300, Andy Shevchenko wrote: > Replace open coded acpi_match_device() in acpi_smbus_cmi_add(). Discard this, a last minute change that makes it not buildable. -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] i2c: scmi: Replace open coded acpi_match_device() 2022-07-01 11:51 ` Andy Shevchenko @ 2022-07-06 19:32 ` Wolfram Sang 2022-07-08 10:02 ` Andy Shevchenko 0 siblings, 1 reply; 4+ messages in thread From: Wolfram Sang @ 2022-07-06 19:32 UTC (permalink / raw) To: Andy Shevchenko; +Cc: linux-i2c, linux-kernel [-- Attachment #1: Type: text/plain, Size: 100 bytes --] > Discard this, a last minute change that makes it not buildable. Do you plan to send an update? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] i2c: scmi: Replace open coded acpi_match_device() 2022-07-06 19:32 ` Wolfram Sang @ 2022-07-08 10:02 ` Andy Shevchenko 0 siblings, 0 replies; 4+ messages in thread From: Andy Shevchenko @ 2022-07-08 10:02 UTC (permalink / raw) To: Wolfram Sang, linux-i2c, linux-kernel On Wed, Jul 06, 2022 at 09:32:05PM +0200, Wolfram Sang wrote: > > > Discard this, a last minute change that makes it not buildable. > > Do you plan to send an update? Just did it. -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-08 10:02 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-06-30 19:55 [PATCH v1 1/1] i2c: scmi: Replace open coded acpi_match_device() Andy Shevchenko 2022-07-01 11:51 ` Andy Shevchenko 2022-07-06 19:32 ` Wolfram Sang 2022-07-08 10:02 ` Andy Shevchenko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).