From: Wolfram Sang <wsa@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org, Kamal Dasu <kdasu.kdev@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
"open list:BROADCOM BRCMSTB I2C DRIVER"
<linux-i2c@vger.kernel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] i2c: brcmstb: Fixed adapter named with optional interrupts
Date: Tue, 19 Jul 2022 05:57:18 +0200 [thread overview]
Message-ID: <YtYrnlmpfRxcWMga@shikoro> (raw)
In-Reply-To: <03065912-a9f0-6380-6f19-9db2f43be589@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 414 bytes --]
> I was not sure if we could change the adapter name reported as one could
> argue this is now ABI, but if we can, then using dev_name() is probably
> better. You are the maintainer you so know the rules on what is considered
> stable ABI and what is not :)
Well, then even removing ":" would break the ABI :)
Please use dev_name. Other drivers changed that string, too. We never
gave guarantees for that one.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-07-19 3:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 17:21 [PATCH] i2c: brcmstb: Fixed adapter named with optional interrupts Florian Fainelli
2022-07-16 12:40 ` Wolfram Sang
2022-07-19 0:15 ` Florian Fainelli
2022-07-19 3:57 ` Wolfram Sang [this message]
2022-07-19 4:06 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtYrnlmpfRxcWMga@shikoro \
--to=wsa@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox