From: Wolfram Sang <wsa@kernel.org>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Sam Protsenko <semen.protsenko@linaro.org>,
Rob Herring <robh@kernel.org>, Sven Peter <sven@svenpeter.dev>,
Jan Dabros <jsd@semihalf.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Tyrone Ting <kfting@nuvoton.com>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
Biju Das <biju.das.jz@bp.renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v4 2/2] i2c: Add Renesas RZ/V2M controller
Date: Fri, 22 Jul 2022 18:07:14 +0200 [thread overview]
Message-ID: <YtrLMr0UeSSKxTFP@shikoro> (raw)
In-Reply-To: <20220708100350.12523-3-phil.edworthy@renesas.com>
Hi Phil,
> Yet another i2c controller from Renesas that is found on the RZ/V2M
> (r9a09g011) SoC. It can support only 100kHz and 400KHz operation.
Geez, you are right with "yet another". One wonders why the 5 others are
not enough?
> +static int rzv2m_i2c_master_xfer1(struct rzv2m_i2c_priv *priv,
> + struct i2c_msg *msg, int stop)
I'd prefer "rzv2m_i2c_master_xfer_msg" for this function.s
> + adap->class = I2C_CLASS_DEPRECATED;
You don't need to set the class to deprecated because there can't be a
previous version which now loses this functionality and needs to inform
userspace about it. .class can be 0 here.
Reset looks looks, good thanks!
I can fix up these minor things when applying if you don't mind.
Happy hacking,
Wolfram
next prev parent reply other threads:[~2022-07-22 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 10:03 [PATCH v4 0/2] i2c: Add new driver for Renesas RZ/V2M controller Phil Edworthy
2022-07-08 10:03 ` [PATCH v4 1/2] dt-bindings: i2c: Document RZ/V2M I2C controller Phil Edworthy
2022-07-22 16:44 ` Wolfram Sang
2022-07-08 10:03 ` [PATCH v4 2/2] i2c: Add Renesas RZ/V2M controller Phil Edworthy
2022-07-08 11:07 ` Andy Shevchenko
2022-07-08 11:56 ` Philipp Zabel
2022-07-22 16:07 ` Wolfram Sang [this message]
2022-08-01 6:46 ` Phil Edworthy
2022-07-22 16:45 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtrLMr0UeSSKxTFP@shikoro \
--to=wsa@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=kfting@nuvoton.com \
--cc=krzk@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=olof@lixom.net \
--cc=p.zabel@pengutronix.de \
--cc=phil.edworthy@renesas.com \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).