From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39D1BC19F28 for ; Wed, 3 Aug 2022 09:14:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234312AbiHCJOn (ORCPT ); Wed, 3 Aug 2022 05:14:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232079AbiHCJOm (ORCPT ); Wed, 3 Aug 2022 05:14:42 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D32F32DBE; Wed, 3 Aug 2022 02:14:40 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A37018B; Wed, 3 Aug 2022 11:14:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1659518077; bh=ublmtGyAQVtFJPiwhQ3vjOrp6RCmG0z0vrymUAfZdh8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gsn23RfPZIH8dIV5U0XCQcjJAfvFk6zXY+AYnBVbKjUcOF/1aA6agPStqBoq42QMH XyeMLOd4Mgw/58aVVZ87oU7LTg/IT+XuJH6k/JtTmrQ5cgS1y1lGEwYZZatk8vXVZ2 vj7gYNnBkqzIemziBVpZmNyMwetOC+SRQP5ZcTE8= Date: Wed, 3 Aug 2022 12:14:31 +0300 From: Laurent Pinchart To: Erling Ljunggren Cc: linux-media@vger.kernel.org, linux-i2c@vger.kernel.org, Srinivas Kandagatla Subject: Re: [PATCH v2 0/5] Add the cat24c208 EDID EEPROM driver + new EDID capability Message-ID: References: <20220803075850.1196988-1-hljunggr@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220803075850.1196988-1-hljunggr@cisco.com> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi Erling, (CC'ing the linux-i2c mailing list and Srinivas, the maintainer of the nvmem framework) Thank you for the patches. On Wed, Aug 03, 2022 at 09:58:45AM +0200, Erling Ljunggren wrote: > This series adds support for the standalone cat24c208 EDID EEPROM i2c device. > Usually EDID support is part of an HDMI receiver, but this is a standalone EEPROM. > > Note that EEPROMs for EDIDs are not regular EEPROM devices, these are dual port > devices that follow the VESA E-DDC standard. > > Since this is a standalone device that does not capture any video a new > V4L2_CAP_EDID_MEMORY capability is introduced to represent such devices. > Note that such a device doesn't have to be an EEPROM, it can also be > implemented using a microcontroller, for example. Hence the use of the generic > word 'MEMORY'. Why can't this be exposed as a nvmem device, like other types of eeproms here ? > The new capability uses the free bit 0x00000008. But we are running out of > capability bits: only 0x40000000 and 0x00000008 are free at the moment. > > There is one other capability V4L2_CAP_ASYNCIO (0x02000000) that is not used > at all, it was never implemented. Wouldn't it be better to define > V4L2_CAP_ASYNCIO to 0, mark it as obsolete, and instead reuse it for this > V4L2_CAP_EDID_MEMORY capability? > > v2: > - fix dt binding example > - rename i2c client variables in data struct > - fix include: of_device.h -> mod_devicetable.h > - Sorted makefile > - used define EDID_OFFSET_EXT_FLAG instead of magic number > - removed of_match_ptr > - added bus_info > - remove unneeded headers > - add depends on OF to Kconfig > > Erling Ljunggren (4): > media: videodev2.h: add V4L2_CAP_EDID_MEMORY > media: docs: Add V4L2_CAP_EDID_MEMORY > dt-bindings: media: add cat24c208 bindings > media: v4l2-dev: handle V4L2_CAP_EDID_MEMORY > > Jonathan Selnes (1): > media: i2c: cat24c208: driver for the cat24c208 EDID EEPROM > > .../bindings/media/i2c/onnn,cat24c208.yaml | 40 ++ > .../userspace-api/media/v4l/biblio.rst | 11 + > .../media/v4l/vidioc-querycap.rst | 7 + > .../media/videodev2.h.rst.exceptions | 1 + > MAINTAINERS | 7 + > drivers/media/i2c/Kconfig | 9 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/cat24c208.c | 421 ++++++++++++++++++ > drivers/media/v4l2-core/v4l2-dev.c | 8 + > include/uapi/linux/videodev2.h | 1 + > 10 files changed, 506 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/onnn,cat24c208.yaml > create mode 100644 drivers/media/i2c/cat24c208.c -- Regards, Laurent Pinchart