public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Asmaa Mnebhi <asmaa@nvidia.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Khalil Blaiech <kblaiech@nvidia.com>
Subject: Re: [PATCH v1 4/7] i2c-mlxbf.c: incorrect base address passed during io write
Date: Thu, 18 Aug 2022 22:24:27 +0200	[thread overview]
Message-ID: <Yv6f+zR9qk5vLOmI@shikoro> (raw)
In-Reply-To: <CH2PR12MB3895EBE43CB5B23F4E4ECA65D76D9@CH2PR12MB3895.namprd12.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]


Thanks for the heads up.

> didn't have any impact on the overall functionality of the read/write transactions. Writing to smbus->io + 0x18 (aka  MLXBF_I2C_CAUSE_OR_CLEAR) corresponds to sc_low_timeout register which sets the timeout value before a read/write transaction aborts. 

I understand. Could we have the above sentences (or something similar)
in the commit message then?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-08-18 20:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16 22:54 [PATCH v1 0/7] i2c-mlxbf.c: bug fixes and new feature support Asmaa Mnebhi
2022-08-16 22:54 ` [PATCH v1 1/7] i2c-mlxbf.c: Fix frequency calculation Asmaa Mnebhi
2022-08-16 22:54 ` [PATCH v1 2/7] i2c-mlxbf.c: remove IRQF_ONESHOT Asmaa Mnebhi
2022-08-16 22:54 ` [PATCH v1 3/7] i2c-mlxbf: add multi slave functionality Asmaa Mnebhi
2022-08-18 16:25   ` Wolfram Sang
2022-08-18 16:41     ` Asmaa Mnebhi
2022-08-16 22:54 ` [PATCH v1 4/7] i2c-mlxbf.c: incorrect base address passed during io write Asmaa Mnebhi
2022-08-18 16:27   ` Wolfram Sang
2022-08-18 16:40     ` Asmaa Mnebhi
2022-08-18 17:21       ` Asmaa Mnebhi
2022-08-18 20:24         ` Wolfram Sang [this message]
2022-08-18 20:30           ` Asmaa Mnebhi
2022-08-16 22:54 ` [PATCH v1 5/7] i2c-mlxbf: prevent stack overflow in mlxbf_i2c_smbus_start_transaction() Asmaa Mnebhi
2022-08-16 22:54 ` [PATCH v1 6/7] i2c-mlxbf.c: support BlueField-3 SoC Asmaa Mnebhi
2022-08-18 15:11   ` Rob Herring
2022-08-18 20:43     ` Asmaa Mnebhi
2022-08-16 22:54 ` [PATCH v1 7/7] i2c-mlxbf.c: support lock mechanism Asmaa Mnebhi
2022-08-18 16:24 ` [PATCH v1 0/7] i2c-mlxbf.c: bug fixes and new feature support Wolfram Sang
2022-08-18 16:42   ` Asmaa Mnebhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yv6f+zR9qk5vLOmI@shikoro \
    --to=wsa@kernel.org \
    --cc=asmaa@nvidia.com \
    --cc=kblaiech@nvidia.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox