Re: [PATCH v2 6/6] i2c: Make remove callback return void

Crt Mori
2022-08-16T10:23:25Z

For mlx90614 and mlx90632:

Acked-by: Crt Mori<cmo@melexis.com>

Best regards,
Crt

On Mon, 15 Aug 2022 at 10:50, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> Hello,
>
> On Mon, Aug 15, 2022 at 10:02:30AM +0200, Uwe Kleine-König wrote:
> > The value returned by an i2c driver's remove function is mostly ignored.
> > (Only an error message is printed if the value is non-zero that the
> > error is ignored.)
> >
> > So change the prototype of the remove function to return no value. This
> > way driver authors are not tempted to assume that passing an error to
> > the upper layer is a good idea. All drivers are adapted accordingly.
> > There is no intended change of behaviour, all callbacks were prepared to
> > return 0 before.
> >
> > [...]
> > ---
> > [...]
> > 619 files changed, 646 insertions(+), 1733 deletions(-)
>
> There seems to be a 300k limit for mails on vger.kernel.org, so this
> patch didn't make it to the list. Please get it from
>
> https://git.pengutronix.de/git/ukl/linux i2c-remove-void
>
> or
>
> https://git.pengutronix.de/cgit/ukl/linux/commit/?h=i2c-remove-void
>
> or send me a (private) mail, then I can bounce you the message to
> properly reply to it. (Or if that is enough for you: The Message-Id is
> <20220815080230.37408-7-u.kleine-koenig@pengutronix.de>.)
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | https://www.pengutronix.de/ |