Re: [PATCH v2 6/6] i2c: Make remove callback return void

Wolfram Sang
2022-08-16T11:26:52Z

[-- Attachment #1: Type: text/plain, Size: 2453 bytes --]

On Mon, Aug 15, 2022 at 10:02:30AM +0200, Uwe Kleine-König wrote:
> The value returned by an i2c driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
>
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
>
> Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com>
> Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au>
> Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> Reviewed-by: Crt Mori <cmo@melexis.com>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Acked-by: Marek Behún <kabel@kernel.org> # for leds-turris-omnia
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Petr Machata <petrm@nvidia.com> # for mlxsw
> Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for surface3_power
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> # for bmc150-accel-i2c + kxcjk-1013
> Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> # for media/* + staging/media/*
> Acked-by: Miguel Ojeda <ojeda@kernel.org> # for auxdisplay/ht16k33 + auxdisplay/lcd2s
> Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net> # for versaclock5
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # for versaclock5
> Reviewed-by: Ajay Gupta <ajayg@nvidia.com> # for ucsi_ccg
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio
> Acked-by: Peter Rosin <peda@axentia.se> # for i2c-mux-*, max9860
> Acked-by: Adrien Grassein <adrien.grassein@gmail.com> # for lontium-lt8912b
> Reviewed-by: Jean Delvare <jdelvare@suse.de> # for hwmon, i2c-core and i2c/muxes
> Acked-by: Corey Minyard <cninyard@mvista.com> # for IPMI
> Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> # for drivers/power
> Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Applied to an immutable branch, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]