From: Wolfram Sang <wsa@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-i2c@vger.kernel.org, kernel@pengutronix.de,
Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 2/6] leds: lm3697: Remove duplicated error reporting in .remove()
Date: Tue, 16 Aug 2022 12:37:53 +0200 [thread overview]
Message-ID: <Yvtzge4/7fGHAwKc@shikoro> (raw)
In-Reply-To: <20220815080230.37408-3-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On Mon, Aug 15, 2022 at 10:02:26AM +0200, Uwe Kleine-König wrote:
> Returning an error value from an i2c remove callback results in an error
> message being emitted by the i2c core, but otherwise it doesn't make a
> difference. The device goes away anyhow and the devm cleanups are
> called.
>
> As lm3697_remove() already emits an error message on failure and the
> additional error message by the i2c core doesn't add any useful
> information, don't pass the error value up the stack. Instead continue
> to clean up and return 0.
>
> This patch is a preparation for making i2c remove callbacks return void.
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to an immutable branch, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-08-16 11:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 8:02 [PATCH v2 0/6] i2c: Make remove callback return void Uwe Kleine-König
2022-08-15 8:02 ` [PATCH v2 1/6] drm/i2c/sil164: Drop no-op remove function Uwe Kleine-König
2022-08-16 10:37 ` Wolfram Sang
2022-08-15 8:02 ` [PATCH v2 2/6] leds: lm3697: Remove duplicated error reporting in .remove() Uwe Kleine-König
2022-08-16 10:37 ` Wolfram Sang [this message]
2022-08-15 8:02 ` [PATCH v2 3/6] leds: lm3601x: Don't use mutex after it was destroyed Uwe Kleine-König
2022-08-16 10:38 ` Wolfram Sang
2022-08-15 8:02 ` [PATCH v2 4/6] leds: lm3601x: Improve error reporting for problems during .remove() Uwe Kleine-König
2022-08-16 10:38 ` Wolfram Sang
2022-08-15 8:02 ` [PATCH v2 5/6] gpio: pca953x: Make platform teardown callback return void Uwe Kleine-König
2022-08-15 14:21 ` Bartosz Golaszewski
2022-08-16 8:16 ` Andy Shevchenko
2022-08-16 8:18 ` Andy Shevchenko
2022-08-16 10:38 ` Wolfram Sang
[not found] ` <20220815080230.37408-7-u.kleine-koenig@pengutronix.de>
2022-08-15 8:50 ` [PATCH v2 6/6] i2c: Make remove " Uwe Kleine-König
2022-08-16 8:34 ` Crt Mori
2022-08-16 10:39 ` Wolfram Sang
2022-08-16 10:59 ` [PATCH v2 0/6] " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yvtzge4/7fGHAwKc@shikoro \
--to=wsa@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox