From: Wolfram Sang <wsa@kernel.org>
To: Yicong Yang <yangyicong@huawei.com>
Cc: Weilong Chen <chenweilong@huawei.com>,
yangyicong@hisilicon.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, xuwei5@huawei.com
Subject: Re: [PATCH next v2 2/2] dt-bindings: i2c: add entry for hisilicon,hisi-i2c
Date: Wed, 7 Sep 2022 23:32:21 +0200 [thread overview]
Message-ID: <YxkN5Q8iCpRaQq4w@shikoro> (raw)
In-Reply-To: <ffa076ea-2675-05ab-00bb-30b77ef13cba@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
> I think it misses some properties here?
>
> - i2c-sda-hold-time-ns
> - sda_fall_ns
> - scl_rise_ns
> ...
>
> Do we need to mention them here?
I think so. But for a definitive answer, the devicetree-list should be
on CC for proper review.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-07 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 9:24 [PATCH next v2 1/2] i2c: i2c-hisi: Add support for initializing control module via DT Weilong Chen
2022-08-25 9:24 ` [PATCH next v2 2/2] dt-bindings: i2c: add entry for hisilicon,hisi-i2c Weilong Chen
2022-08-31 9:53 ` Yicong Yang
2022-09-02 1:00 ` chenweilong
2022-09-07 21:32 ` Wolfram Sang [this message]
2022-08-31 9:44 ` [PATCH next v2 1/2] i2c: i2c-hisi: Add support for initializing control module via DT Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxkN5Q8iCpRaQq4w@shikoro \
--to=wsa@kernel.org \
--cc=chenweilong@huawei.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xuwei5@huawei.com \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox