From: Wolfram Sang <wsa@kernel.org>
To: Tharunkumar.Pasumarthi@microchip.com
Cc: UNGLinuxDriver@microchip.com, krzk@kernel.org, arnd@arndb.de,
andriy.shevchenko@linux.intel.com, robh@kernel.org,
semen.protsenko@linaro.org, sven@svenpeter.dev,
jarkko.nikula@linux.intel.com, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, jsd@semihalf.com, olof@lixom.net,
rafal@milecki.pl
Subject: Re: [PATCH v4 i2c-master] i2c: microchip: pci1xxxx: Add driver for I2C host controller in multifunction endpoint of pci1xxxx switch
Date: Fri, 23 Sep 2022 18:24:34 +0200 [thread overview]
Message-ID: <Yy3dwhFSTBH9942n@shikoro> (raw)
In-Reply-To: <55e6769b1d7e890f4211b44f821b11654a5b9f4d.camel@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 558 bytes --]
> > I need to make sure: do you intentionally want autoprobing for SPD? I
> > ask because it could be needed but it costs boottime when not needed.
> > And changing the class once exposed is troublesome.
>
> Autoprobing is not required. I can modify code.
>
> All these comments need to be addressed now or can be fixed later after the
> patch is applied?
The issue above (autoprobing) should really not be fixed incrementally.
The other two issues could be, but if you need to resend anyhow, just
tackle them as well, please.
Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-09-23 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 16:11 [PATCH v4 i2c-master] i2c: microchip: pci1xxxx: Add driver for I2C host controller in multifunction endpoint of pci1xxxx switch Tharun Kumar P
2022-09-07 16:32 ` Andy Shevchenko
2022-09-16 9:04 ` Tharunkumar.Pasumarthi
2022-09-17 21:02 ` Wolfram Sang
2022-09-17 21:01 ` Wolfram Sang
2022-09-23 13:51 ` Tharunkumar.Pasumarthi
2022-09-23 16:24 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy3dwhFSTBH9942n@shikoro \
--to=wsa@kernel.org \
--cc=Tharunkumar.Pasumarthi@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=krzk@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).