From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B84C6FA86 for ; Wed, 14 Sep 2022 09:42:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230474AbiINJmx (ORCPT ); Wed, 14 Sep 2022 05:42:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231172AbiINJm2 (ORCPT ); Wed, 14 Sep 2022 05:42:28 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 258EB32AB5; Wed, 14 Sep 2022 02:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663148528; x=1694684528; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KygSRb8RNrq6ueX2RVvRzI4GlM9IvgjpZfDFHSuvf9I=; b=HD2cffVnRwWgEaSEMDuD4Ok07WPghqktwKfpdnGWMsXlXK6lBYSV2ooz ndYfcn0HAx72JgbvVf1zQlguPxaplgAOR8zcH5NQzHhVJRbsKH/idNg7P RW1Dxl2x8yEiD/439ZZYvf/LH5BvLiGY3KsgGGSjtvJWxBFmSylltCGYe C3bNZJJD6U3xHkG0JTBdoxMhS8RsWb5/Zbh422ULWzvNvVwGD1X6KetbN z8p9Hfq28aCLIdNX3IVGLXY1ncRPSvbJNsQ4R/HpOXMWgisWCBwRbXf3e zmwdDDv2KeOM565P2YHjDrSTotx/cYGZKohfUu6LYoCUGWuYWs1hTu4n6 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10469"; a="278114977" X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="278114977" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 02:42:07 -0700 X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="685251593" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 02:42:04 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oYOu9-0028hA-2F; Wed, 14 Sep 2022 12:42:01 +0300 Date: Wed, 14 Sep 2022 12:42:01 +0300 From: Andy Shevchenko To: Raul Rangel Cc: Linux ACPI , linux-input , "jingle.wu" , "Limonciello, Mario" , Tim Van Patten , Linus Walleij , Hans de Goede , "Rafael J. Wysocki" , Mika Westerberg , Wolfram Sang , "open list:I2C SUBSYSTEM HOST DRIVERS" , linux-kernel Subject: Re: [PATCH v2 07/13] i2c: acpi: Use ACPI wake capability bit to set wake_irq Message-ID: References: <20220912221317.2775651-1-rrangel@chromium.org> <20220912160931.v2.7.I8af4282adc72eb9f247adcd03676a43893a020a6@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Tue, Sep 13, 2022 at 12:56:37PM -0600, Raul Rangel wrote: > On Tue, Sep 13, 2022 at 12:33 PM Andy Shevchenko > wrote: > > On Tue, Sep 13, 2022 at 12:07:53PM -0600, Raul Rangel wrote: ... > > This is similar to what of_i2c_get_board_info() does, no? > > Note: _get_ there. > > `*info` is an out parameter in that case. Ideally I would have > `i2c_acpi_get_irq`, `acpi_dev_gpio_irq_get_wake`, > `platform_get_irq_optional`, and `i2c_dev_irq_from_resources` all > return a `struct irq_info {int irq; bool wake_capable;}`. This would > be a larger change though. Seems the ACPI analogue is i2c_acpi_fill_info(). Can we do it there? -- With Best Regards, Andy Shevchenko