From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00DCDC54EE9 for ; Mon, 19 Sep 2022 13:59:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230028AbiISN7v (ORCPT ); Mon, 19 Sep 2022 09:59:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230122AbiISN7q (ORCPT ); Mon, 19 Sep 2022 09:59:46 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CE5B6445; Mon, 19 Sep 2022 06:59:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663595985; x=1695131985; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZDrlPJ8c7h2ypE+fbKsa96aFWpumfpvi6BmS/TWfKLE=; b=EJgq3/AJkVR6iyVJtvgt3VRoXDmLMpBWJOGPpndu91zShNF4Fn5YDxpg eLzBBPLHYQ+EsuM0bUrhPoztJ5bFrTn88o5TEHxjxIsLcDX6MJQb8UDKb ppwsQJs32U3gKNf5BaibHjqd8LhgdzXVpV6WRLnvUyAOF4R90TsZL7VK5 OTeKtT+QqUHAopB6a9wymp/fZMZ0LrtppWf5e0R0Hzmftp/GbXwQJt5kE JjcSVHKGNAfYX35DgTSX+kgONR/Wejb0dFxPAK//cSEsxOraBZWXIyBAK n3Oa3O1gmnMoFLS+tXES6o72UdZYaSjvfVb6yw0k/v2MQR//AfaTHBaeQ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10475"; a="296999046" X-IronPort-AV: E=Sophos;i="5.93,327,1654585200"; d="scan'208";a="296999046" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2022 06:59:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,327,1654585200"; d="scan'208";a="686983272" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 19 Sep 2022 06:59:42 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oaHJF-004a6U-0V; Mon, 19 Sep 2022 16:59:41 +0300 Date: Mon, 19 Sep 2022 16:59:40 +0300 From: Andy Shevchenko To: Jan Dabros Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, jarkko.nikula@linux.intel.com, wsa@kernel.org, rrangel@chromium.org, upstream@semihalf.com, mario.limonciello@amd.com Subject: Re: [PATCH -next 1/2] i2c: designware: Switch from using MMIO access to SMN access Message-ID: References: <20220916131854.687371-1-jsd@semihalf.com> <20220916131854.687371-2-jsd@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220916131854.687371-2-jsd@semihalf.com> Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oZDg0-003IXN-16; Fri, 16 Sep 2022 18:54:48 +0300 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Fri, Sep 16, 2022 at 03:18:53PM +0200, Jan Dabros wrote: > Due to a change in silicon compared to Cezanne, in future revisions MSR > access can't be used to get the base address of the PSP MMIO region that > contains the PSP mailbox interface. > > Modify driver to use SMN access also for Cezanne platforms (it is > working there) in order to simplify codebase when adding support for new > SoC versions. > > Export amd_cache_northbridges() which was unexported by > e1907d3: "x86/amd_nb: Unexport amd_cache_northbridges()" Please, use standard format of referring to the commits in the history (basically the same as for Fixes tags). > since function which registers i2c-designware-platdrv is a > subsys_initcall that is executed before fs_initcall (when enumeration of > NB descriptors occurs). Thus in order to use SMN accesses it's necessary > to explicitly call amd_cache_northrbidges() from within this driver. Also it doesn't clarify if this commit a full revert of that (rebased for new kernel versions) or partial or functional? -- With Best Regards, Andy Shevchenko