From: Wolfram Sang <wsa@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
krzk@kernel.org, jarkko.nikula@linux.intel.com, robh@kernel.org,
semen.protsenko@linaro.org, sven@svenpeter.dev, jsd@semihalf.com,
rafal@milecki.pl, olof@lixom.net, arnd@arndb.de,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v4 i2c-master] i2c: microchip: pci1xxxx: Add driver for I2C host controller in multifunction endpoint of pci1xxxx switch
Date: Sat, 17 Sep 2022 23:02:58 +0200 [thread overview]
Message-ID: <YyY2Aic+WIylNA02@shikoro> (raw)
In-Reply-To: <YxjHgiqrGauhg1oS@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 883 bytes --]
On Wed, Sep 07, 2022 at 07:32:02PM +0300, Andy Shevchenko wrote:
> On Wed, Sep 07, 2022 at 09:41:43PM +0530, Tharun Kumar P wrote:
> > Microchip pci1xxxx is an unmanaged PCIe3.1a Switch for Consumer,
> > Industrial and Automotive applications. This switch has multiple
> > downstream ports. In one of the Switch's Downstream port, there
> > is a multifunction endpoint for peripherals which includes an I2C
> > host controller. The I2C function in the endpoint operates at 100KHz,
> > 400KHz and 1 MHz and has buffer depth of 128 bytes.
> > This patch provides the I2C controller driver for the I2C function
> > of the switch.
>
> There are still possible nit-picks, but it's good enough to be applied
> as is now.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks a lot! However, no need to quote all the 1300+ lines for that
IMHO.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-17 21:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 16:11 [PATCH v4 i2c-master] i2c: microchip: pci1xxxx: Add driver for I2C host controller in multifunction endpoint of pci1xxxx switch Tharun Kumar P
2022-09-07 16:32 ` Andy Shevchenko
2022-09-16 9:04 ` Tharunkumar.Pasumarthi
2022-09-17 21:02 ` Wolfram Sang [this message]
2022-09-17 21:01 ` Wolfram Sang
2022-09-23 13:51 ` Tharunkumar.Pasumarthi
2022-09-23 16:24 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyY2Aic+WIylNA02@shikoro \
--to=wsa@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=krzk@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=sven@svenpeter.dev \
--cc=tharunkumar.pasumarthi@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).