From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01FFDC6FA82 for ; Thu, 22 Sep 2022 14:04:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229621AbiIVOEp (ORCPT ); Thu, 22 Sep 2022 10:04:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231612AbiIVOEm (ORCPT ); Thu, 22 Sep 2022 10:04:42 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5808BE06; Thu, 22 Sep 2022 07:04:40 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 072CB21999; Thu, 22 Sep 2022 14:04:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1663855479; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yu2dqhupNEC5iZs4+QvOOYP9YrBIF4Tg60Iod4b+qF4=; b=UqI9VdnJrGsbX9aHUXUR8RH53iDpu1pKXLbsNGDSjUCj+SGI/3OX2vQwDxftUd3QB1N+ew i3P2oY7o7EpyteyY4CCQUxBub5c5qGabAyn9jwjzdBa37W/XSmOJxHswmxKWGY4vP/L3oi lNjClDQL2+zZ+xWgCDnf4U0IT0YQPb4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1663855479; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yu2dqhupNEC5iZs4+QvOOYP9YrBIF4Tg60Iod4b+qF4=; b=ks14P5/57VzpYLvOWbdOQ3PzH3gualwQbiRB/GcAchUs+0nt+dFi8c8atQVZ53LLzlHGHe UIOBIbtWBuGwwvBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ECDDF13AA5; Thu, 22 Sep 2022 14:04:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3xLLOXZrLGNUCQAAMHmgww (envelope-from ); Thu, 22 Sep 2022 14:04:38 +0000 Date: Thu, 22 Sep 2022 16:04:38 +0200 From: Borislav Petkov To: Hans de Goede Cc: Andy Shevchenko , "Limonciello, Mario" , Jan =?utf-8?B?RMSFYnJvxZs=?= , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, jarkko.nikula@linux.intel.com, wsa@kernel.org, rrangel@chromium.org, upstream@semihalf.com, Muralidhara M K , Naveen Krishna Chatradhi Subject: Re: [PATCH -next 1/2] i2c: designware: Switch from using MMIO access to SMN access Message-ID: References: <20220916131854.687371-1-jsd@semihalf.com> <20220916131854.687371-2-jsd@semihalf.com> <60a52348-7d50-1056-a596-e154f87c99d2@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Thu, Sep 22, 2022 at 03:48:07PM +0200, Hans de Goede wrote: > Right, thank you for Cc-ing me. At least on X86 there are several platforms > (and 100-s of device models) which use a PMIC connected to the i2c-designware > controller and this PMIC gets poked directly from ACPI _S0 and _S3 > (power on/off) methods. So the I2C bus driver needs to *bind* to the controller > as soon as we find its description in ACPI, otherwise we get a whole bunch > of failed ACPI OpRegion access errors as well as various actual really issues. Thanks for explaining - I couldn't find the reason why it has to be a subsys_initcall. > So please keep this as a subsys initcall. Which means, init_amd_nbs() would have to be sorted to run before dw_i2c_init_driver()... -- Regards/Gruss, Boris. SUSE Software Solutions Germany GmbH GF: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman (HRB 36809, AG Nürnberg)