Re: [PATCH v6 4/5] i2c: i2c-mlxbf.c: support BlueField-3 SoC

Wolfram Sang
2022-09-27T19:53:25Z

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

> + ret = mlxbf_i2c_init_resource(pdev, &priv->smbus,
> + MLXBF_I2C_SMBUS_RES);

Did you maybe forget to check 'ret' here?

> + priv->timer->io = priv->smbus->io;
> + priv->mst->io = priv->smbus->io + MLXBF_I2C_MST_ADDR_OFFSET;
> + priv->slv->io = priv->smbus->io + MLXBF_I2C_SLV_ADDR_OFFSET;

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]