From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Asmaa Mnebhi <asmaa@nvidia.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Khalil Blaiech <kblaiech@nvidia.com>
Subject: Re: [PATCH v7 1/2] i2c: mlxbf: support BlueField-3 SoC
Date: Tue, 27 Sep 2022 22:46:52 +0200 [thread overview]
Message-ID: <YzNhPL0lUeqjCymv@shikoro> (raw)
In-Reply-To: <20220927203924.22644-2-asmaa@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]
On Tue, Sep 27, 2022 at 04:39:23PM -0400, Asmaa Mnebhi wrote:
> BlueField-3 SoC has the same I2C IP logic as previous
> BlueField-1 and 2 SoCs but it has different registers' addresses.
> This is an effort to keep this driver generic accross all
> BlueField generations.
> This patch breaks down the "smbus" resource into 3 separate
> resources to enable us to use common registers' offsets for all
> BlueField SoCs:
> struct mlxbf_i2c_resource *timer;
> struct mlxbf_i2c_resource *mst;
> struct mlxbf_i2c_resource *slv;
>
> Of course, all offsets had to be adjusted accordingly, and we took
> this chance to reorganize the macros depending on the register block
> they target.
>
> There are only 2 registers' offsets that do not fit within this
> schema so their offsets are passed as SoC-specific parameters:
> smbus_master_rs_bytes_off
> smbus_master_fsm_off
>
> Reviewed-by: Khalil Blaiech <kblaiech@nvidia.com>
> Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-27 20:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 20:39 [PATCH v7 0/2] i2c: i2c-mlxbf.c: bug fixes and new feature support Asmaa Mnebhi
2022-09-27 20:39 ` [PATCH v7 1/2] i2c: mlxbf: support BlueField-3 SoC Asmaa Mnebhi
2022-09-27 20:46 ` Wolfram Sang [this message]
2022-09-27 21:00 ` Asmaa Mnebhi
2022-09-27 20:39 ` [PATCH v7 2/2] i2c: mlxbf: remove device tree support Asmaa Mnebhi
2022-09-27 20:46 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzNhPL0lUeqjCymv@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=asmaa@nvidia.com \
--cc=kblaiech@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox