public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Andi Shyti <andi.shyti@kernel.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Jan Dabros <jsd@semihalf.com>,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: designware: Actually make use of the I2C_DW_COMMON and I2C_DW symbol namespaces
Date: Tue, 3 Dec 2024 21:27:35 +0200	[thread overview]
Message-ID: <Z09bp9uMzwXRLXuF@smile.fi.intel.com> (raw)
In-Reply-To: <20241203173640.1648939-2-u.kleine-koenig@baylibre.com>

On Tue, Dec 03, 2024 at 06:36:40PM +0100, Uwe Kleine-König wrote:
> DEFAULT_SYMBOL_NAMESPACE must already be defined when <linux/export.h>
> is included. So move the define above the include block.

As in the other email I pointed out the doc says that we need to undef the
symbol. No need to move it around.

The only requirement is to place that before any EXPORT_SYMBOL*() we want to
add it to.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-12-03 19:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03 17:36 [PATCH] i2c: designware: Actually make use of the I2C_DW_COMMON and I2C_DW symbol namespaces Uwe Kleine-König
2024-12-03 19:27 ` Andy Shevchenko [this message]
2024-12-03 22:46   ` Uwe Kleine-König
2024-12-04  1:23     ` Andy Shevchenko
2024-12-04 10:25       ` Uwe Kleine-König
2024-12-05  7:53         ` Andy Shevchenko
2024-12-05  8:12           ` Jarkko Nikula
2024-12-05  8:26             ` Andy Shevchenko
2024-12-27  0:07               ` Andi Shyti
2024-12-28 21:45                 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z09bp9uMzwXRLXuF@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jsd@semihalf.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox