Re: [PATCH v3] i2c: imx: add imx7d compatible string for applying errata ERR007805

Oleksij Rempel
2024-12-19T05:55:21Z

do not exist?
> compatible string table, at the result, "fsl,imx21-i2c" will be
> matched, but it will cause errata ERR007805 not be applied in fact.
>
> So Add "fsl,imx7d-i2c" compatible string in i2c-imx driver to apply
> the errata ERR007805(https://www.nxp.com/webapp/Download?colCode=
> IMX7DS_2N09P).

This link is not working, may be this one:
https://www.nxp.com/docs/en/errata/IMX7DS_3N09P.pdf

More practical is to include the erratum text with list of affected SoC
variants.

> "fsl,imx7d-i2c" already is documented in binding doc. This errata

s/errata/erratum

Errata is plural
Erratum is singular

> fix has been included in imx6_i2c_hwdata and it is the same in all
> I.MX6/7/8, so just reuse it.
>

Please Fixes tag, this patch should go stable:
Fixes: 39c025721d70 ("i2c: imx: Implement errata ERR007805 or e7805 bus frequency limit")
Cc: stable@vger.kernel.org

> Signed-off-by: Carlos Song <carlos.song@nxp.com>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>

With fixes in the commit message you can add my:
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>

> ---
> Change for V3:
> - No ACK, so resend this patch.
> Change for V2:
> - I have tried to fix this issue at imx7s.dtsi in V1, according to
> the community suggestion, I make V2 patch for i2c-imx driver to
> avoid updating the FDT to fix an errata. Discussion in V1:
> Subject: [PATCH] ARM: dts: imx7s: change i2c compatible string for applying errata ERR007805
> Message-ID: <20241021031148.2682015-1-carlos.song@nxp.com> (raw)
> ---
> drivers/i2c/busses/i2c-imx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 350346a7892c..9d5caa032c5c 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -335,6 +335,7 @@ static const struct of_device_id i2c_imx_dt_ids[] = {
> { .compatible = "fsl,imx6sll-i2c", .data = &imx6_i2c_hwdata, },
> { .compatible = "fsl,imx6sx-i2c", .data = &imx6_i2c_hwdata, },
> { .compatible = "fsl,imx6ul-i2c", .data = &imx6_i2c_hwdata, },
> + { .compatible = "fsl,imx7d-i2c", .data = &imx6_i2c_hwdata, },
> { .compatible = "fsl,imx7s-i2c", .data = &imx6_i2c_hwdata, },
> { .compatible = "fsl,imx8mm-i2c", .data = &imx6_i2c_hwdata, },
> { .compatible = "fsl,imx8mn-i2c", .data = &imx6_i2c_hwdata, },
> --
> 2.34.1
>
>

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |