Re: [PATCH v5] i2c: imx: support DMA defer probing

Oleksij Rempel
2024-12-20T11:47:06Z

On Fri, Dec 20, 2024 at 11:51:27AM +0100, Ahmad Fatoum wrote:
> Hi Carlos,
>
> On 20.12.24 11:46, Carlos Song wrote:
> >
> >
> >> -----Original Message-----
> >> From: Ahmad Fatoum <a.fatoum@pengutronix.de>
> >> Sent: Friday, December 20, 2024 5:32 PM
> >> To: Carlos Song <carlos.song@nxp.com>; Oleksij Rempel
>
> >> I know -110, but -12 I need to look up :) Both are cryptic to end users, which is
> >> why %pe was added on top of the existing %p:
> >>
> >> If CONFIG_SYMBOLIC_ERRNAME is enabled %pe expands to an error string, e.g.
> >> "ENOMEM" or "ETIMEDOUT". If it's disabled, you get the same error number
> >> that was printed raw before.
> >>
> >> Cheers,
> >> Ahmad
> >>
> >
> > Wow! Looks so cool.
> > Thank you very much for your patient explanation! I agree it.
> >
> > Also I will change the comment from your suggestion[1]:
> >
> > "
> > /*
> > * As we can always fall back to PIO, let's ignore the error setting up
> > * DMA and see if we run into errors while setting up PIO mode.
> > */
> > "
> > In fact, other errors are also from DMA setting not from setting PIO mode.
> > So can I comment simply like this?
> >
> > /* As we can always fall back to PIO, let's ignore the error setting up DMA. */
> > ret = i2c_imx_dma_request(i2c_imx, phy_addr);
> > if (ret) {
> > if (ret == -EPROBE_DEFER)
> > goto clk_notifier_unregister;
> > else if (ret == -ENODEV)
> > dev_dbg(&pdev->dev, "Only use PIO mode\n");
> > else
> > dev_err(&pdev->dev, "Failed to setup DMA (%pe), only use PIO mode\n", ERR_PTR(ret));
> > }
> >
> > [1]https://lore.kernel.org/imx/89a3b1c9-2be2-4e7f-a0c6-abbf8b88957b@pengutronix.de/
>
> Sure, looks good to me. @Oleksij?

Ack, looks good. Thank you!