Re: [PATCH v2 0/9] Add support for I2C bus recovery for riic driver

Andi Shyti
2024-12-26T01:24:39Z

Hi,

> Lad Prabhakar (9):
> i2c: riic: Replace dev_err with dev_err_probe in probe function
> i2c: riic: Use local `dev` pointer in `dev_err_probe()`

just a change re-ordering here.

> i2c: riic: Use BIT macro consistently
> i2c: riic: Use GENMASK() macro for bitmask definitions

I'm OK with these two patches to be separate.

> i2c: riic: Make use of devres helper to request deasserted reset line
> i2c: riic: Mark riic_irqs array as const
> i2c: riic: Use predefined macro and simplify clock tick calculation
> i2c: riic: Add `riic_bus_barrier()` to check bus availability
> i2c: riic: Implement bus recovery

There were a few comments on this patch '9' that are waiting for
a follow up.

If you want you can split the series and send patches 1-8 and I
can merge them in the meantime. Patch '9' can be taken once we
are sure about the change from a hardware perspective.

Thanks,
Andi