From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fgw20-7.mail.saunalahti.fi (fgw20-7.mail.saunalahti.fi [62.142.5.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 464002744B for ; Sat, 28 Dec 2024 23:36:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735428982; cv=none; b=aRc5bK6fY2Ck7DRmNBNDmxegZPxuIiijW1BIQjqQ4mpc04UeaW9dh6VDHwxI3nNfokw8g3KSHWlhC23RIEhdVcwPeGXh8HSiZXQ88aDhp3DOJtIJjID+dyEQFInTE9v+mcVpo7dIVGyChDdy4iVS4TJW+Vf35wB2VbhKdiCJfSc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735428982; c=relaxed/simple; bh=2Q6s2b4H5T/TFfZxexsTDIaXQWsP0D2YL2gOlXxZcVo=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a8P0kv6YGRzyzfRbD0diXJ4WI9UlQ8W4gssRQEn+F0NMUj5IHG0aNauQqys3ylTj3HESS991EAKk6LYmCE1hMKcp+7MYRunPm7mZow1Hv5eu08X35fHK1cYDEay84emCvyg/m35TKJQp8j25XwrDqH6JlfjBCkr+3jKjplt1HMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-25-143.elisa-laajakaista.fi [88.113.25.143]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id 59c7d618-c574-11ef-9c75-005056bd6ce9; Sun, 29 Dec 2024 01:34:59 +0200 (EET) From: Andy Shevchenko Date: Sun, 29 Dec 2024 01:34:58 +0200 To: Prabhakar Cc: Chris Brandt , Andi Shyti , Geert Uytterhoeven , Wolfram Sang , Philipp Zabel , linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Fabrizio Castro , Lad Prabhakar , Claudiu Beznea Subject: Re: [PATCH v3 3/8] i2c: riic: Use BIT macro consistently Message-ID: References: <20241227115154.56154-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20241227115154.56154-4-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241227115154.56154-4-prabhakar.mahadev-lad.rj@bp.renesas.com> Fri, Dec 27, 2024 at 11:51:49AM +0000, Prabhakar kirjoitti: > From: Lad Prabhakar > > Easier to read and ensures proper types. ... > #include > #include Does it include bits.h or equivalent (bitops.h, bitmap.h)? -- With Best Regards, Andy Shevchenko