Re: [PATCH] i2c: amd756: Fix endianness handling for word data

Andi Shyti
2025-01-03T23:50:28Z

On Sat, Jan 04, 2025 at 12:28:47AM +0100, Wolfram Sang wrote:
> > Now, you're treating it as a fix, which is perfectly fine. For
> > me, it's a 50-50 case.
>
> For me, this is a clear no-fix case as long as nobody really reported
> problems (which I am not aware of). Also, looking at the Kconfig text,
> it looks unlikely to me that this controller has been used with big
> endian systems. Or?

Yeah! That was my first thought, but because this was reported
by LKP (which I respect more than other code analyzers) as a
potential issue, I was on the 50-50.

I still agree that the patch is correct because there's a
hanging comment. So, either remove the comment or go with
Athrva's approach.

Urgh, I'm just leaving things as they are :-)

Andi