From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Jarkko Nikula" <jarkko.nikula@linux.intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Jan Dabros" <jsd@semihalf.com>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2] i2c: designware: Actually make use of the I2C_DW_COMMON and I2C_DW symbol namespaces
Date: Mon, 13 Jan 2025 11:43:53 +0200 [thread overview]
Message-ID: <Z4TgWaqZnpr5u6sp@smile.fi.intel.com> (raw)
In-Reply-To: <wkx55fripv35i4pv5jnosx2s37dm54mrik2r6cfzjkl6poekmz@sagdynptzopn>
On Sat, Jan 04, 2025 at 12:51:57AM +0100, Andi Shyti wrote:
> Hi Uwe,
>
> On Mon, Dec 30, 2024 at 04:59:49PM +0100, Uwe Kleine-König wrote:
> > DEFAULT_SYMBOL_NAMESPACE must already be defined when <linux/export.h>
> > is included. So move the define above the include block.
> >
> > Fixes: fd57a3325a77 ("i2c: designware: Move exports to I2C_DW namespaces")
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> > ---
> > Hello,
> >
> > Changes since (implicit) v1 that is available at
> > https://lore.kernel.org/linux-i2c/20241203173640.1648939-2-u.kleine-koenig@baylibre.com:
> >
> > - Also fix drivers/i2c/busses/i2c-designware-master.c
> > - Make added line breaks consistent
>
> Thanks for this v2. I need to wait for Andy's ack, though, as he
> had some comments here.
Documentation fixes already were applied and this one follows it, so fine with
me:
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-01-13 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-30 15:59 [PATCH v2] i2c: designware: Actually make use of the I2C_DW_COMMON and I2C_DW symbol namespaces Uwe Kleine-König
2024-12-31 13:48 ` Jarkko Nikula
2025-01-03 23:51 ` Andi Shyti
2025-01-13 9:43 ` Andy Shevchenko [this message]
2025-01-14 13:25 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4TgWaqZnpr5u6sp@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox