From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: Chris Brandt <chris.brandt@renesas.com>,
Andi Shyti <andi.shyti@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v6 08/10] i2c: riic: Use predefined macro and simplify clock tick calculation
Date: Tue, 14 Jan 2025 11:17:31 +0100 [thread overview]
Message-ID: <Z4Y5u5ys-w_kD4yC@shikoro> (raw)
In-Reply-To: <20250113122643.819379-9-prabhakar.mahadev-lad.rj@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
On Mon, Jan 13, 2025 at 12:26:41PM +0000, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Replace the hardcoded `1000000000` with the predefined `NSEC_PER_SEC`
> macro for clarity. Simplify the code by introducing a `ns_per_tick`
> variable to store `NSEC_PER_SEC / rate`, reducing redundancy and
> improving readability.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-01-14 10:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 12:26 [PATCH v6 00/10] i2c: riic: Add support for I2C bus recovery, along with driver cleanup and improvements Prabhakar
2025-01-13 12:26 ` [PATCH v6 01/10] i2c: riic: Introduce a separate variable for IRQ Prabhakar
2025-01-13 12:26 ` [PATCH v6 02/10] i2c: riic: Use dev_err_probe in probe and riic_init_hw functions Prabhakar
2025-01-13 12:26 ` [PATCH v6 03/10] i2c: riic: Use local `dev` pointer in `dev_err_probe()` Prabhakar
2025-01-13 12:26 ` [PATCH v6 04/10] i2c: riic: Use BIT macro consistently Prabhakar
2025-01-13 12:26 ` [PATCH v6 05/10] i2c: riic: Use GENMASK() macro for bitmask definitions Prabhakar
2025-01-13 12:26 ` [PATCH v6 06/10] i2c: riic: Make use of devres helper to request deasserted reset line Prabhakar
2025-01-13 12:26 ` [PATCH v6 07/10] i2c: riic: Mark riic_irqs array as const Prabhakar
2025-01-13 12:26 ` [PATCH v6 08/10] i2c: riic: Use predefined macro and simplify clock tick calculation Prabhakar
2025-01-14 10:17 ` Wolfram Sang [this message]
2025-01-13 12:26 ` [PATCH v6 09/10] i2c: riic: Add `riic_bus_barrier()` to check bus availability Prabhakar
2025-01-13 12:26 ` [PATCH v6 10/10] i2c: riic: Implement bus recovery Prabhakar
2025-01-13 19:20 ` [PATCH v6 00/10] i2c: riic: Add support for I2C bus recovery, along with driver cleanup and improvements Andy Shevchenko
2025-01-14 10:53 ` Wolfram Sang
2025-01-14 13:05 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4Y5u5ys-w_kD4yC@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=chris.brandt@renesas.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox