From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Heiner Kallweit" <hkallweit1@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Joe Hattori" <joe@pf.is.s.u-tokyo.ac.jp>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Hans de Goede" <hdegoede@redhat.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "i2c: core: Allocate temp client on the stack in i2c_detect"
Date: Sat, 22 Feb 2025 10:32:19 +0100 [thread overview]
Message-ID: <Z7mZo7k3p1Po3hD5@shikoro> (raw)
In-Reply-To: <20250221205449.3838714-1-arnd@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
On Fri, Feb 21, 2025 at 09:54:40PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> struct i2c_client is way too large to be put on the kernel stack, and depending
> on the kernel configuration, this can exceed the compile-time warning limit:
>
> drivers/i2c/i2c-core-base.c:1420:12: error: stack frame size (1040) exceeds limit (1024) in 'i2c_do_add_adapter' [-Werror,-Wframe-larger-than]
> 1420 | static int i2c_do_add_adapter(struct i2c_driver *driver,
> | ^
>
> The current version is the result of a cleanup patch that does not appear
> to be a requirement for anything else, so address the problem through a
> simple revert.
>
> Fixes: 735668f8e5c9 ("i2c: core: Allocate temp client on the stack in i2c_detect")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thank you, yet Geert was faster and fixed a checkpatch check:
https://lore.kernel.org/r/f9aa39362e918b62aec0567f899b37d8d3c44710.1740064176.git.geert+renesas@glider.be
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-02-22 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 20:54 [PATCH] Revert "i2c: core: Allocate temp client on the stack in i2c_detect" Arnd Bergmann
2025-02-21 21:29 ` Guenter Roeck
2025-02-22 9:32 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7mZo7k3p1Po3hD5@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=joe@pf.is.s.u-tokyo.ac.jp \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox