From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Yixun Lan <dlan@gentoo.org>, Longbin Li <looong.bin@gmail.com>
Subject: Re: [PATCH] i2c: designware: Add ACPI HID for DWAPB I2C controller on Sophgo SG2044
Date: Tue, 4 Mar 2025 13:47:26 +0200 [thread overview]
Message-ID: <Z8boTsGU-o2MwNZ2@smile.fi.intel.com> (raw)
In-Reply-To: <Z8bnX8zcY3yIxh9n@smile.fi.intel.com>
On Tue, Mar 04, 2025 at 01:43:27PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 04, 2025 at 03:02:11PM +0800, Inochi Amaoto wrote:
> > Add ACPI ID for DWAPB I2C controller on Sophgo SG2044 so
> > the SoC can enumerated the device via ACPI.
>
> Same as per UART:
>
> ---8<---
>
> This is fake ACPI ID. Please work with a vendor to issue the proper one.
> Vendor ACPI ID registry has no records on Sophgo:
> https://uefi.org/ACPI_ID_List?acpi_search=SophGo
>
> NAK.
>
> ---8<---
>
> But, it might be that is already in the process of getting proper ACPI vendor
> ID, please provide an evidence in such a case.
Looking even closer to the ID, it is completely bogus as it uses CAPITAL O
instead of 0 in device ID part.
> Otherwise drag the representative of the vendor to this email thread to answer
> the question why the heck they abuse ACPI specification.
So, go and work with the vendor to fix their misunderstanding of ACPI and tell
them that they are free to contact me for the details. I will glad to help them
to make right things right.
Also read this success story of similar case:
https://andy-shev.dreamwidth.org/151340.html
and feel free to share with the vendor.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-03-04 11:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 7:02 [PATCH] i2c: designware: Add ACPI HID for DWAPB I2C controller on Sophgo SG2044 Inochi Amaoto
2025-03-04 11:43 ` Andy Shevchenko
2025-03-04 11:46 ` Inochi Amaoto
2025-03-04 11:53 ` Andy Shevchenko
2025-03-04 11:47 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8boTsGU-o2MwNZ2@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=dlan@gentoo.org \
--cc=inochiama@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=looong.bin@gmail.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox