From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30156167DB7; Mon, 17 Mar 2025 09:31:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742203870; cv=none; b=tAuIePkB/cwWz3LlgjKv4hMjRioNa6Ezr3sQF+hbdxdXrhW6F/7JY7Nm72pqIJhkbfldP1DkhFazuiH8Yzr2aYQMOKmLl1ESL4e3YQgwWixoa7MbaSY9xBKCJZKR/tK5PmNZ8JFRZjxo/xqoz1zHJ7jnbprQDUL6DOx6MZ61cHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742203870; c=relaxed/simple; bh=7Nf3hHf8dKej995NglyVR9ZqEaj2C0bxlftFTKPalqY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=u8hiV4jVKvfBC+xft51IoqVDpPd/xXNBPurxkeG26mpiLHXVNdGbpkhLLbThzfaHS0lNmXGJhV0d3NG+rY2DlEgeha+X9OL5aXps7Yi0rFaiJu1Y7k83gpWqeFOYVxQXAxkO9VH/8Nn1NuNTUEQCrTLej8/NsBGip3YkNcsabmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org; spf=fail smtp.mailfrom=kernel.org; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=kernel.org X-CSE-ConnectionGUID: XsQz/D4WSoSdT1n1Uqe8+A== X-CSE-MsgGUID: m+4AUw2wTu6MvY7cmuCu4g== X-IronPort-AV: E=McAfee;i="6700,10204,11375"; a="43026822" X-IronPort-AV: E=Sophos;i="6.14,253,1736841600"; d="scan'208";a="43026822" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2025 02:31:08 -0700 X-CSE-ConnectionGUID: pBR0xImMQ8+NXonsTk34yw== X-CSE-MsgGUID: IizAQ4D4QEejbszgwRPrWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,253,1736841600"; d="scan'208";a="121692078" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2025 02:31:04 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1tu6oH-00000003GYa-3SeD; Mon, 17 Mar 2025 11:31:01 +0200 Date: Mon, 17 Mar 2025 11:31:01 +0200 From: Andy Shevchenko To: Francesco Dolcini Cc: Emanuele Ghidoli , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emanuele Ghidoli , Francesco Dolcini , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Arnd Bergmann , soc@kernel.org, Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= Subject: Re: [RFC PATCH v1 2/2] platform: toradex: add preliminary support for Embedded Controller Message-ID: References: <20250313144331.70591-1-francesco@dolcini.it> <20250313144331.70591-3-francesco@dolcini.it> <20250317083911.GA17428@francesco-nb> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250317083911.GA17428@francesco-nb> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Mar 17, 2025 at 09:39:11AM +0100, Francesco Dolcini wrote: > On Thu, Mar 13, 2025 at 04:53:35PM +0200, Andy Shevchenko wrote: > > On Thu, Mar 13, 2025 at 03:43:31PM +0100, Francesco Dolcini wrote: ... > > > + err = regmap_bulk_read(ec->regmap, EC_CHIP_ID_REG, ®_val, EC_ID_VERSION_LEN); > > > + if (err) > > > + return dev_err_probe(dev, err, > > > + "Cannot read id and version registers\n"); > > > + > > > + dev_info(dev, "Toradex Embedded Controller id %x - Firmware %d.%d\n", > > > > Specifiers are semirandom. Why signed? Why x and not %u? > > The firmware version ("Firmware %d.%d") is two unsigned decimal number, > so yes, I will change to "Firmware %u.%u". > > The ID is just an identifier that is documented as hex, therefore I > think that the most convenient way to display it is as a hex number. Thanks, don't forget to summarize this in the commit message, it seems useful information. -- With Best Regards, Andy Shevchenko