From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andi Shyti <andi.shyti@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH 1/2] i2c: i801: Switch to iomapped register access
Date: Wed, 19 Mar 2025 00:18:47 +0200 [thread overview]
Message-ID: <Z9nxRwoeLEriKP84@surfacebook.localdomain> (raw)
In-Reply-To: <67535b17-c3fb-4507-b083-9c1884b4dd7d@gmail.com>
Wed, Mar 12, 2025 at 08:07:23PM +0100, Heiner Kallweit kirjoitti:
> Switch to iomapped register access as a prerequisite for adding
> support for MMIO register access.
I believe that I at least discussed the similar change a few years ago or even
proposed a one. The problem here is that *_p() variants of IO port accessors
are not the same as non-_p ones. And commit message is kept silent about
possible consequences of this change.
So, at bare minumum it would be good to test for some period of time before
going for it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-18 22:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 19:06 [PATCH 0/2] i2c: i801: Use MMIO if available Heiner Kallweit
2025-03-12 19:07 ` [PATCH 1/2] i2c: i801: Switch to iomapped register access Heiner Kallweit
2025-03-18 22:18 ` Andy Shevchenko [this message]
2025-03-18 23:22 ` Andi Shyti
2025-03-19 7:17 ` Heiner Kallweit
2025-03-19 8:23 ` Andy Shevchenko
2025-03-19 19:33 ` Heiner Kallweit
2025-03-19 19:48 ` Andy Shevchenko
2025-03-19 20:26 ` Heiner Kallweit
2025-03-19 21:53 ` Andi Shyti
2025-03-20 20:06 ` Heiner Kallweit
2025-03-20 21:06 ` Andy Shevchenko
2025-03-20 21:10 ` Andi Shyti
2025-03-12 19:08 ` [PATCH 2/2] i2c: i801: Use MMIO if available Heiner Kallweit
2025-03-12 23:58 ` [PATCH 0/2] " Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9nxRwoeLEriKP84@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox