Re: [RFC PATCH 3/3] i2c: i2c-core-of: Handle i2c bus extensions

Krzysztof Kozlowski
2025-02-12T05:54:26Z

On 05/02/2025 18:39, Herve Codina wrote:
>
> dev_dbg(&adap->dev, "of_i2c: walking child nodes from %pOF\n", bus);
>
> - /* Register device directly attached to this bus */
> + /*
> + * Register device directly described in this bus node before looking
> + * at extensions.
> + */
> for_each_available_child_of_node(bus, node) {
> + /* Filter out extension node */
> + if (of_node_name_eq(node, "i2c-bus-extension"))

Where is the ABI documented?

> + continue;
> +
> if (of_node_test_and_set_flag(node, OF_POPULATED))
> continue;
>
> @@ -103,6 +110,23 @@ static void of_i2c_register_children(struct i2c_adapter *adap,
> of_node_clear_flag(node, OF_POPULATED);
> }
> }
> +
> + /* Look at extensions */
> + for_each_available_child_of_node(bus, node) {
> + if (!of_node_name_eq(node, "i2c-bus-extension"))
> + continue;
> +
> + extension = of_parse_phandle(node, "i2c-bus", 0);

And this?

> + if (!extension)
> + continue;
> +
Best regards,
Krzysztof