From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: "Mario Limonciello" <mario.limonciello@amd.com>,
"Jan Dąbroś" <jsd@semihalf.com>,
"Grzegorz Bernacki" <gjb@semihalf.com>,
Rijo-john.Thomas@amd.com, Thomas.Lendacky@amd.com,
herbert@gondor.apana.org.au,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 9/9] i2c: designware: Add support for AMDI0020 ACPI ID
Date: Mon, 6 Mar 2023 14:55:26 +0200 [thread overview]
Message-ID: <ZAXiviOdddEK/Pak@smile.fi.intel.com> (raw)
In-Reply-To: <0a872110-3f38-0744-17f1-74de3e78f84d@linux.intel.com>
On Mon, Mar 06, 2023 at 02:28:05PM +0200, Jarkko Nikula wrote:
> On 3/6/23 14:04, Andy Shevchenko wrote:
> > On Fri, Mar 03, 2023 at 10:50:47AM -0600, Mario Limonciello wrote:
> > > Cezanne and Skyrim have the same PSP hardware but use a different
> > > protocol to negotiate I2C arbitration. To disambiguate this going
> > > forward introduce a new ACPI ID to represent the protocol that utilizes
> > > a doorbell.
...
> > > - if (boot_cpu_data.x86 == 25 && boot_cpu_data.x86_model == 80)
> >
> > Ah, in this form it's getting better than I thought!
> >
> These removed lines were added by previous patch. I think a bit too short
> lived if the same patchset adds and then removes lines?
That what I have missed. Okay, coming to square 1, i.e. dropping CPU ID
completely from the series.
Note, for testing purposes you may always add a HACK patch at the end of the
series, marking it respectively. So, people may test it all and maintainer
apply w/o unneeded tail.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-06 12:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 16:50 [PATCH v3 0/9] Export platform features from ccp driver Mario Limonciello
2023-03-03 16:50 ` [PATCH v3 2/9] crypto: ccp: Add a header for multiple drivers to use `__psp_pa` Mario Limonciello
2023-03-07 23:42 ` Sean Christopherson
2023-03-03 16:50 ` [PATCH v3 3/9] crypto: ccp: Move some PSP mailbox bit definitions into common header Mario Limonciello
2023-03-03 16:50 ` [PATCH v3 6/9] i2c: designware: Use PCI PSP driver for communication Mario Limonciello
2023-03-03 16:50 ` [PATCH v3 8/9] i2c: designware: Add doorbell support for Skyrim Mario Limonciello
2023-03-03 16:50 ` [PATCH v3 9/9] i2c: designware: Add support for AMDI0020 ACPI ID Mario Limonciello
2023-03-06 12:04 ` Andy Shevchenko
2023-03-06 12:28 ` Jarkko Nikula
2023-03-06 12:55 ` Andy Shevchenko [this message]
2023-03-06 13:11 ` Mario Limonciello
2023-03-07 21:22 ` Limonciello, Mario
2023-03-03 20:58 ` [PATCH v3 0/9] Export platform features from ccp driver Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAXiviOdddEK/Pak@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Rijo-john.Thomas@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=gjb@semihalf.com \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).