From: Wolfram Sang <wsa@kernel.org>
To: Yicong Yang <yangyicong@huawei.com>
Cc: linux-i2c@vger.kernel.org, chenweilong@huawei.com,
f.fangjian@huawei.com, linuxarm@huawei.com,
prime.zeng@huawei.com, yangyicong@hisilicon.com,
Sheng Feng <fengsheng5@huawei.com>
Subject: Re: [PATCH 2/2] i2c: hisi: Only use the completion interrupt to finish the transfer
Date: Thu, 16 Mar 2023 21:06:53 +0100 [thread overview]
Message-ID: <ZBN23VqLFzGyMn2U@shikoro> (raw)
In-Reply-To: <20230313074552.54457-3-yangyicong@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On Mon, Mar 13, 2023 at 03:45:52PM +0800, Yicong Yang wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>
>
> The controller will always generate a completion interrupt when the
> transfer is finished normally or not. Currently we use either error or
> completion interrupt to finish, this may result the completion
> interrupt unhandled and corrupt the next transfer, especially at low
> speed mode. Since on error case, the error interrupt will come first
> then is the completion interrupt. So only use the completion interrupt
> to finish the whole transfer process.
>
> Fixes: d62fbdb99a85 ("i2c: add support for HiSilicon I2C controller")
> Reported-by: Sheng Feng <fengsheng5@huawei.com>
> Signed-off-by: Sheng Feng <fengsheng5@huawei.com>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-03-16 20:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 7:45 [PATCH 0/2] Improvement and fix for HiSilicon I2C driver Yicong Yang
2023-03-13 7:45 ` [PATCH 1/2] i2c: hisi: Avoid redundant interrupts Yicong Yang
2023-03-16 20:06 ` Wolfram Sang
2023-03-13 7:45 ` [PATCH 2/2] i2c: hisi: Only use the completion interrupt to finish the transfer Yicong Yang
2023-03-16 20:06 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBN23VqLFzGyMn2U@shikoro \
--to=wsa@kernel.org \
--cc=chenweilong@huawei.com \
--cc=f.fangjian@huawei.com \
--cc=fengsheng5@huawei.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=prime.zeng@huawei.com \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox