From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: "Jan Dąbroś" <jsd@semihalf.com>,
"Grzegorz Bernacki" <gjb@semihalf.com>,
"Mark Hasemeyer" <markhas@chromium.org>,
"Jarkko Nikula" <jarkko.nikula@linux.intel.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 4/4] i2c: designware: Add doorbell support for Mendocino
Date: Thu, 23 Mar 2023 15:06:09 +0200 [thread overview]
Message-ID: <ZBxOwTggrZTvJf2H@smile.fi.intel.com> (raw)
In-Reply-To: <20230322210227.464-5-mario.limonciello@amd.com>
On Wed, Mar 22, 2023 at 04:02:26PM -0500, Mario Limonciello wrote:
> Mendocino and later platform don't use the platform feature mailbox for
> communication for I2C arbitration, they rely upon ringing a doorbell.
>
> Detect the platform by the device ID of the root port and choose the
> appropriate method.
...
> - ret = read_poll_timeout(psp_send_i2c_req_cezanne, status,
> + ret = read_poll_timeout(_psp_send_i2c_req, status,
> (status != -EBUSY),
You can place it now in the above line, but up to you.
> PSP_I2C_REQ_RETRY_DELAY_US,
> PSP_I2C_REQ_RETRY_CNT * PSP_I2C_REQ_RETRY_DELAY_US,
...
> + /* Cezanne uses platform mailbox, Mendocino and later use doorbell */
> + rdev = pci_get_domain_bus_and_slot(0, 0, PCI_DEVFN(0, 0));
> + if (rdev->device == 0x1630)
> + _psp_send_i2c_req = psp_send_i2c_req_cezanne;
> + else
> + _psp_send_i2c_req = psp_send_i2c_req_mendocino;
Where is pci_dev_put()?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-23 13:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 21:02 [PATCH v6 0/4] Use CCP driver to handle PSP I2C arbitration Mario Limonciello
2023-03-22 21:02 ` [PATCH v6 3/4] i2c: designware: Use PCI PSP driver for communication Mario Limonciello
2023-03-23 13:08 ` Andy Shevchenko
2023-03-23 18:34 ` kernel test robot
2023-03-24 2:35 ` kernel test robot
2023-03-22 21:02 ` [PATCH v6 4/4] i2c: designware: Add doorbell support for Mendocino Mario Limonciello
2023-03-23 13:06 ` Andy Shevchenko [this message]
2023-03-23 13:32 ` Limonciello, Mario
2023-03-24 20:40 ` kernel test robot
2023-03-27 16:37 ` Mark Hasemeyer
2023-03-27 17:05 ` Limonciello, Mario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBxOwTggrZTvJf2H@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gjb@semihalf.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=markhas@chromium.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox