From: Wolfram Sang <wsa@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Michal Simek <michal.simek@amd.com>,
Shubhrajyoti Datta <Shubhrajyoti.datta@amd.com>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: xiic: xiic_xfer(): Fix runtime PM leak on error path
Date: Tue, 18 Apr 2023 18:44:52 +0200 [thread overview]
Message-ID: <ZD7JBIjrmWTEGYqi@shikoro> (raw)
In-Reply-To: <20230414021022.505291-2-lars@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
On Thu, Apr 13, 2023 at 07:10:22PM -0700, Lars-Peter Clausen wrote:
> The xiic_xfer() function gets a runtime PM reference when the function is
> entered. This reference is released when the function is exited. There is
> currently one error path where the function exits directly, which leads to
> a leak of the runtime PM reference.
>
> Make sure that this error path also releases the runtime PM reference.
>
> Fixes: fdacc3c7405d ("i2c: xiic: Switch from waitqueue to completion")
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-04-18 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 2:10 [PATCH 1/2] i2c: cadence: cdns_i2c_master_xfer(): Fix runtime PM leak on error path Lars-Peter Clausen
2023-04-14 2:10 ` [PATCH 2/2] i2c: xiic: xiic_xfer(): " Lars-Peter Clausen
2023-04-14 12:57 ` Michal Simek
2023-04-18 16:44 ` Wolfram Sang [this message]
2023-04-14 12:57 ` [PATCH 1/2] i2c: cadence: cdns_i2c_master_xfer(): " Michal Simek
2023-04-18 16:44 ` Wolfram Sang
2023-04-24 9:28 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZD7JBIjrmWTEGYqi@shikoro \
--to=wsa@kernel.org \
--cc=Shubhrajyoti.datta@amd.com \
--cc=lars@metafoo.de \
--cc=linux-i2c@vger.kernel.org \
--cc=michal.simek@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox