From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD5A1C7EE32 for ; Mon, 5 Jun 2023 09:25:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbjFEJZJ (ORCPT ); Mon, 5 Jun 2023 05:25:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231211AbjFEJZI (ORCPT ); Mon, 5 Jun 2023 05:25:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27335DF; Mon, 5 Jun 2023 02:25:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A9C1B621BE; Mon, 5 Jun 2023 09:25:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A829C433D2; Mon, 5 Jun 2023 09:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685957106; bh=2vmmK+h5PPIQLJpVOoUh89ZNQLOuPRABXJRcoZvm1MI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V7X/5cmJkUW0wqW++Tft1ozAEGUwqdyFzyv/PZrmfUK+4xcV8I+he1y6mwZMbteXo TXvSr62lOvqBPePVzeIMf3YYDJ7cngTfPlt3f/z7Qkd3s/1m+R/KAK1Wte9Njr++0k 0GHqtzGRassZ084k0kOWE1d06i1ciqiA9PDUztEtiXtnY6dZ56C3ZR7BrJxo53+FjR cEvBlimgenvyC2FVJMVUENPEIOi5op4v+YbwoC1goc87k7VZOJBFLV7HBE1LjVeV4t jZxS+h5j1RZZKTgi9r65sy1jeffJ2Xqvr2d8I711bNYOntgHNYbegjOm+WmeivF3pT 3kuIvd5Iskobw== Date: Mon, 5 Jun 2023 11:25:02 +0200 From: Wolfram Sang To: Biju Das Cc: Alessandro Zummo , Alexandre Belloni , linux-i2c@vger.kernel.org, linux-rtc@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2] i2c: Add i2c_get_match_data() Message-ID: Mail-Followup-To: Wolfram Sang , Biju Das , Alessandro Zummo , Alexandre Belloni , linux-i2c@vger.kernel.org, linux-rtc@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , linux-renesas-soc@vger.kernel.org References: <20230601171711.221430-1-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yCBX5AlPw0rYAlLc" Content-Disposition: inline In-Reply-To: <20230601171711.221430-1-biju.das.jz@bp.renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org --yCBX5AlPw0rYAlLc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + if (client->dev.of_node) > config = of_device_get_match_data(&client->dev); Has it been considered adding this check to the new helper function as well? Saves even more boilerplate code, I'd think. --yCBX5AlPw0rYAlLc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmR9qe4ACgkQFA3kzBSg KbbXcRAAiqqWhEzO2IUNv5glBXaA9C0Ad0/rf6jrOOsMuiR4ajw/+AJ7yQDBw7MC SWJ0gYjMOgv/pJupdP0lii5M1hUDMljKyfLwjnAbhtXeOM3QQRZ+cqWfoDDfbE3r EKIEa37vKjF99+D4uK/godfXrJf7hzTTgLMDBIMUW1SRao7vQIjC66xhGOi4iqs8 7EBLBm59HxSchUIBw0IpiZa+Dy/DwV+sjU66vLPln93aujsOkOt81I+WaasB4BX7 ysh0Jzk9Oeuk5wjs0HwRMeI5RS6BayE9chL4UGFwpkySSt2e16Q5YxLm9MUlE2+k 3wGkQ/qyUPVDoYcwBOMew9piBoID9qOXFdx+8fkaYEkbaqO7ZZuL9jVmuOjvpC0o 9LvY5uOooIymg1Dkwr37wctWZ3pBCNhC6BXpEjNsz5EQDcOmg+l08YmSRgty/aW4 hsDQ4lK6fiD4MJI5C5baiMStEN+1tMU9oltmCRjWKmFCtXhRtjjiZJcJKCAyXWYb QeWkk/UnCpUga1oyl2k1lo4+RkeR8Kc0Tm3IqOrFinMx8XTDSxplsDJT0fPAFqvN wYJVRa7oBhZ6slObMIyvW6j/vDIy8mqekbvx90g4tzCRw0UPVSuB3xqtCtPm4kE9 SPLnssoFyxD2QIM73wrYhwFZZibLhw/8qpsiQdr6OzdAXQBnEvU= =8N9i -----END PGP SIGNATURE----- --yCBX5AlPw0rYAlLc--