From: Wolfram Sang <wsa@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-i2c@vger.kernel.org, linux-rtc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3] i2c: Add i2c_get_match_data()
Date: Wed, 7 Jun 2023 11:00:23 +0200 [thread overview]
Message-ID: <ZIBHJ9XdvX0FUQKz@shikoro> (raw)
In-Reply-To: <20230606130519.382304-1-biju.das.jz@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
On Tue, Jun 06, 2023 at 02:05:19PM +0100, Biju Das wrote:
> Add i2c_get_match_data() to get match data for both I2C and
> DT-based matching, so that we can optimize the driver code that
> uses both.
>
> Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2->v3:
> * Added support for getting match data for both I2C and DT-based
> matching.
> * Added Rb tag from Geert and retained the Rb tag as change is trivial.
Not so trivial, I think. Codewise yes, but the scope of the function
changed as it includes DT now. So, in deed, I would appreciate a comment
from Geert if he is okay with this change.
I personally think it looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-06-07 9:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 13:05 [PATCH v3] i2c: Add i2c_get_match_data() Biju Das
2023-06-07 7:21 ` Biju Das
2023-06-07 9:28 ` Geert Uytterhoeven
2023-06-07 9:36 ` Biju Das
2023-06-07 10:20 ` Wolfram Sang
2023-06-07 16:47 ` Biju Das
2023-06-07 10:17 ` Wolfram Sang
2023-06-07 9:00 ` Wolfram Sang [this message]
2023-06-07 9:06 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIBHJ9XdvX0FUQKz@shikoro \
--to=wsa@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox