From: Wolfram Sang <wsa@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
kernel@pengutronix.de, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: sprd: Delete i2c adapter in .remove's error path
Date: Wed, 7 Jun 2023 12:30:45 +0200 [thread overview]
Message-ID: <ZIBcVUiEr4VprXt6@shikoro> (raw)
In-Reply-To: <20230309095819.2569646-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
On Thu, Mar 09, 2023 at 10:58:19AM +0100, Uwe Kleine-König wrote:
> If pm runtime resume fails the .remove callback used to exit early. This
> resulted in an error message by the driver core but the device gets
> removed anyhow. This lets the registered i2c adapter stay around with an
> unbound parent device.
>
> So only skip clk disabling if resume failed, but do delete the adapter.
>
> Fixes: 8b9ec0719834 ("i2c: Add Spreadtrum I2C controller driver")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-06-07 10:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 9:58 [PATCH] i2c: sprd: Delete i2c adapter in .remove's error path Uwe Kleine-König
2023-03-09 11:17 ` Andy Shevchenko
2023-03-09 12:04 ` Uwe Kleine-König
2023-05-30 13:53 ` Uwe Kleine-König
2023-06-06 16:16 ` Andi Shyti
2023-06-15 8:34 ` Geert Uytterhoeven
2023-06-07 10:30 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIBcVUiEr4VprXt6@shikoro \
--to=wsa@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox