From: Wolfram Sang <wsa@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-i2c@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-clk@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v4] i2c: Add i2c_get_match_data()
Date: Fri, 9 Jun 2023 17:25:21 +0200 [thread overview]
Message-ID: <ZINEYYxGBSQ0mKyV@shikoro> (raw)
In-Reply-To: <20230607165738.138357-1-biju.das.jz@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On Wed, Jun 07, 2023 at 05:57:38PM +0100, Biju Das wrote:
> Add i2c_get_match_data() to get match data for I2C, ACPI and
> DT-based matching, so that we can optimize the driver code.
>
> Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
No further comments, yet I like it, so:
Applied to for-next, thanks!
With one minor change, I hope you are okay with it:
> + struct device_driver *drv = client->dev.driver;
> + struct i2c_driver *driver = to_i2c_driver(drv);
Variables 'drv' and 'driver' sounds like it could cause confusion later.
I merged the two and eliminated 'drv' that way.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-06-09 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 16:57 [PATCH v4] i2c: Add i2c_get_match_data() Biju Das
2023-06-09 15:25 ` Wolfram Sang [this message]
2023-06-09 15:34 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZINEYYxGBSQ0mKyV@shikoro \
--to=wsa@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox