From: Wolfram Sang <wsa@kernel.org>
To: Shuai Jiang <d202180596@hust.edu.cn>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
"Ivan T. Ivanov" <iivanov@mm-sol.com>,
Sricharan R <sricharan@codeaurora.org>,
Naveen Kaje <nkaje@codeaurora.org>,
Austin Christ <austinwc@codeaurora.org>,
hust-os-kernel-patches@googlegroups.com,
Andy Gross <agross@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: qup: Add missing unwind goto in qup_i2c_probe()
Date: Wed, 14 Jun 2023 10:45:35 +0200 [thread overview]
Message-ID: <ZIl+L+KTMclMXMQd@shikoro> (raw)
In-Reply-To: <20230418135612.598-1-d202180596@hust.edu.cn>
[-- Attachment #1: Type: text/plain, Size: 685 bytes --]
On Tue, Apr 18, 2023 at 09:56:12PM +0800, Shuai Jiang wrote:
> Smatch Warns:
> drivers/i2c/busses/i2c-qup.c:1784 qup_i2c_probe()
> warn: missing unwind goto?
>
> The goto label "fail_runtime" and "fail" will disable qup->pclk,
> but here qup->pclk failed to obtain, in order to be consistent,
> change the direct return to goto label "fail_dma".
>
> Fixes: 10c5a8425968 ("i2c: qup: New bus driver for the Qualcomm QUP I2C controller")
> Fixes: 515da746983b ("i2c: qup: add ACPI support")
> Signed-off-by: Shuai Jiang <d202180596@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Applied to for-current, thanks! Thanks Andi, for the proper Fixes tag!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-06-14 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 13:56 [PATCH] i2c: qup: Add missing unwind goto in qup_i2c_probe() Shuai Jiang
2023-05-05 1:18 ` d202180596
2023-05-05 7:42 ` Dan Carpenter
2023-06-10 10:54 ` Andi Shyti
2023-06-14 8:45 ` Wolfram Sang [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-04-18 13:26 Shuai Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIl+L+KTMclMXMQd@shikoro \
--to=wsa@kernel.org \
--cc=agross@codeaurora.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=austinwc@codeaurora.org \
--cc=d202180596@hust.edu.cn \
--cc=hust-os-kernel-patches@googlegroups.com \
--cc=iivanov@mm-sol.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nkaje@codeaurora.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox