From: Wolfram Sang <wsa@kernel.org>
To: Wang Zhang <silver_code@hust.edu.cn>
Cc: Peter Korsgaard <peter@korsgaard.com>,
Andrew Lunn <andrew@lunn.ch>,
Andreas Larsson <andreas@gaisler.com>,
hust-os-kernel-patches@googlegroups.com,
Peter Korsgaard <jacmet@sunsite.dk>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] i2c: ocores: use devm_ managed clks
Date: Fri, 23 Jun 2023 10:22:24 +0200 [thread overview]
Message-ID: <ZJVWQIZRb49mhofo@shikoro> (raw)
In-Reply-To: <20230526070534.76112-1-silver_code@hust.edu.cn>
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
On Fri, May 26, 2023 at 03:05:33PM +0800, Wang Zhang wrote:
> Smatch complains that:
> drivers/i2c/busses/i2c-ocores.c:704 ocores_i2c_probe()
> warn: missing unwind goto?
>
> If any wrong occurs in ocores_i2c_of_probe, the i2c->clk needs to be
> released. But the function returns directly without freeing the clock.
>
> Fix this by updating the code to use devm_clk_get_optional_enabled()
> instead. Use dev_err_probe() where appropriate as well since we are
> changing those statements.
>
> Fixes: f5f35a92e44a ("i2c: ocores: Add irq support for sparc")
> Signed-off-by: Wang Zhang <silver_code@hust.edu.cn>
Applied to for-next with Andrew's Rev-by from v3 added, thanks!
Please send new versions of a patch as a new mail thread. This makes
handling easier for maintainers.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-06-23 8:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-16 7:20 [PATCH] i2c: ocores: add missing unwind goto in `ocores_i2c_probe` Wang Zhang
2023-04-16 15:33 ` Andrew Lunn
2023-04-17 13:27 ` [PATCH v2] i2c: ocores: use devm_ managed clks Wang Zhang
2023-04-17 14:05 ` Wang Zhang
2023-04-17 14:29 ` Peter Rosin
2023-04-17 15:50 ` Andrew Lunn
2023-04-22 12:32 ` [PATCH v3] " Wang Zhang
2023-04-25 9:58 ` 张网
2023-04-25 11:57 ` Andrew Lunn
2023-04-25 14:47 ` 张网
2023-04-25 15:06 ` Andrew Lunn
2023-05-26 7:05 ` [PATCH v4] " Wang Zhang
2023-06-13 23:54 ` Andi Shyti
2023-06-23 8:22 ` Wolfram Sang [this message]
2023-06-23 8:26 ` Wolfram Sang
2023-05-23 4:49 ` Re: [PATCH v3] " 张网
2023-05-23 12:10 ` Andrew Lunn
2023-05-23 14:33 ` Wang Zhang
2023-05-24 15:35 ` Wang Zhang
2023-05-24 15:43 ` Wang Zhang
2023-05-24 18:45 ` Dan Carpenter
2023-05-24 19:21 ` Christophe JAILLET
2023-05-25 3:33 ` 张网
2023-05-25 19:16 ` Christophe JAILLET
2023-05-25 5:05 ` Dan Carpenter
2023-05-25 5:02 ` Dan Carpenter
2023-05-25 9:28 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJVWQIZRb49mhofo@shikoro \
--to=wsa@kernel.org \
--cc=andreas@gaisler.com \
--cc=andrew@lunn.ch \
--cc=hust-os-kernel-patches@googlegroups.com \
--cc=jacmet@sunsite.dk \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@korsgaard.com \
--cc=silver_code@hust.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox