Re: [PATCH v2] i2c: hix5hd2: Make sure clk is disabled in remove

Wolfram Sang
2023-06-23T10:12:15Z

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

On Fri, Jun 09, 2023 at 12:55:13AM +0200, Andi Shyti wrote:
> From: Alexey Khoroshilov <khoroshilov@ispras.ru>
>
> pm_runtime_set_suspended() does not lead to call of suspend callback,
> so clk may be left undisabled in hix5hd2_i2c_remove().
>
> By the way, the patch adds error handling for clk_prepare_enable().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> Signed-off-by: Andi Shyti <andi.shyti@kernel.org>

I have now applied "[PATCH 05/15] i2c: busses: hix5hd2: Use
devm_clk_get_enabled()". Can this patch then be dropped entirely?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]