From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andi Shyti <andi.shyti@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-rtc@vger.kernel.org, linux-iio@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v6 4/4] i2c: Add i2c_device_get_match_data() callback
Date: Fri, 4 Aug 2023 17:55:18 +0300 [thread overview]
Message-ID: <ZM0RVjKWtqXK8sFe@smile.fi.intel.com> (raw)
In-Reply-To: <ZM0RIEshpTV4Sn0q@smile.fi.intel.com>
On Fri, Aug 04, 2023 at 05:54:25PM +0300, Andy Shevchenko wrote:
> On Fri, Aug 04, 2023 at 08:09:15AM +0100, Biju Das wrote:
> > Add i2c_device_get_match_data() callback to struct bus_type().
Actually should be "... struct bus_type." here (no parentheses).
Please, fix in v7.
> > While at it, introduced i2c_get_match_data_helper() to avoid code
> > duplication with i2c_get_match_data().
>
> LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-04 14:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 7:09 [PATCH v6 0/4] Extend device_get_match_data() to struct bus_type Biju Das
2023-08-04 7:09 ` [PATCH v6 1/4] drivers: fwnode: " Biju Das
2023-08-04 14:10 ` Greg Kroah-Hartman
2023-08-04 7:09 ` [PATCH v6 2/4] i2c: i2c-core-of: Convert i2c_of_match_device_sysfs() to non-static Biju Das
2023-08-04 7:09 ` [PATCH v6 3/4] i2c: Enhance i2c_get_match_data() Biju Das
2023-08-04 14:50 ` Andy Shevchenko
2023-08-04 15:20 ` Biju Das
2023-08-04 7:09 ` [PATCH v6 4/4] i2c: Add i2c_device_get_match_data() callback Biju Das
2023-08-04 14:54 ` Andy Shevchenko
2023-08-04 14:55 ` Andy Shevchenko [this message]
2023-08-04 15:23 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZM0RVjKWtqXK8sFe@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jic23@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox