From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D70C001B0 for ; Mon, 7 Aug 2023 14:34:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231274AbjHGOel (ORCPT ); Mon, 7 Aug 2023 10:34:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229948AbjHGOek (ORCPT ); Mon, 7 Aug 2023 10:34:40 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54D1710DC; Mon, 7 Aug 2023 07:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691418879; x=1722954879; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=v4xqKW8p2viTjPZQBKfB1fbP8M/LmC87fd1WQSSQbrU=; b=hEpbQOIMfmBqF1Z4yWPewwLErbpkeX78uFjKKJuU/T34c+ZZ0RnmxmMp Rew44FeTK1DTHpusxA1DBGZtfwsg9dtugW+o+eVKbqEpV5tvUYUKIcwMN aQJxNQUIzKjB8n7l65sLLBA4noHN+qi+BOFqsUJ/E6pKymi0y+EfESLk8 YIL6NuGQOKd2UxcvNomTO9IKGef8TYZpmMc39u2NqYWFFBKixgUvNzhlM oMuiVpgSZByp+ErF2shTbAdGTzgiHKqS4j3hM64sRwvSXq/vGFIr7gWxx l2vbWfZyShQvfO8l9MPTScr3R0TRh4ySs3MTrEktZuQ7tl/nkYk7X8Hlc w==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="436889884" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="436889884" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 07:34:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="845047448" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="845047448" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 07 Aug 2023 07:34:09 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qT1J9-00FWTt-2h; Mon, 07 Aug 2023 17:34:07 +0300 Date: Mon, 7 Aug 2023 17:34:07 +0300 From: Andy Shevchenko To: Andi Shyti Cc: Jarkko Nikula , Mario Limonciello , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Mika Westerberg , Jan Dabros Subject: Re: [PATCH v1 5/9] i2c: designware: Always provide ID tables Message-ID: References: <20230725143023.86325-1-andriy.shevchenko@linux.intel.com> <20230725143023.86325-6-andriy.shevchenko@linux.intel.com> <7be19d99-b197-662c-5157-dfdd9c793e3c@linux.intel.com> <20230804210055.i4hnjsr4ltfak53e@intel.intel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230804210055.i4hnjsr4ltfak53e@intel.intel> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Fri, Aug 04, 2023 at 11:00:55PM +0200, Andi Shyti wrote: > On Mon, Jul 31, 2023 at 11:05:05PM +0300, Andy Shevchenko wrote: > > On Fri, Jul 28, 2023 at 03:33:59PM +0300, Jarkko Nikula wrote: > > > On 7/25/23 17:30, Andy Shevchenko wrote: ... > > > > +/* Work with hotplug and coldplug */ > > > > +MODULE_ALIAS("platform:i2c_designware"); > > > > > > Perhaps this comment can be retired, i.e. dropped. > > > > Then it needs to be done in a separate patch, because in the other file the > > comment will be left untouched. > > You are being a bit too religios here... No, it's being consistent. Either we remove them both or don't touch. > if you want to stick to > this, then you need to send a patch for sorting by ID, a patch > for grouping together MODULE_*, a patch to remove this comment > and a patch to always provide the id table. > > I think, "while at it", you can safely remove the redundant > comment :) > > It doesn't make too much difference to me anyway: > > Reviewed-by: Andi Shyti Thank you! -- With Best Regards, Andy Shevchenko