From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Minjie Du <duminjie@vivo.com>
Cc: Andi Shyti <andi.shyti@kernel.org>,
"open list:I2C SUBSYSTEM HOST DRIVERS"
<linux-i2c@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
opensource.kernel@vivo.com, stable@vger.kernel.org
Subject: Re: [PATCH v4] i2c: gpio: Fix an error check in i2c_gpio_fault_injector_init()
Date: Mon, 14 Aug 2023 17:59:42 +0200 [thread overview]
Message-ID: <ZNpPbhqNqD90VuN1@shikoro> (raw)
In-Reply-To: <20230713101829.15548-1-duminjie@vivo.com>
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
> - if (!i2c_gpio_debug_dir)
> + if (IS_ERR(i2c_gpio_debug_dir))
> return;
AFAIK, the trend is to remove error checking from debugfs calls. It is
debug only anyhow. No need to bail out. But please double check.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-08-14 16:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 10:18 [PATCH v4] i2c: gpio: Fix an error check in i2c_gpio_fault_injector_init() Minjie Du
2023-08-14 15:59 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNpPbhqNqD90VuN1@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=duminjie@vivo.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox