From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90DF6C001DB for ; Tue, 15 Aug 2023 15:51:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236014AbjHOPvO (ORCPT ); Tue, 15 Aug 2023 11:51:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238333AbjHOPuw (ORCPT ); Tue, 15 Aug 2023 11:50:52 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6772819AD; Tue, 15 Aug 2023 08:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692114620; x=1723650620; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=K0JZTVhvNPhS+KagU0AwU1+jE52diqOAFD8zzX9VIOo=; b=Td7WtI0DDdKEkPSWV3rTbmcVxNS+FkUIF5f5MDQ8hYMfJkgQOxgmvAlB ZSmGXuEChXzY5rxBfLaw762dn/Brpj0/tcsSyD+CArbED+sQxsntDInlw JJV21Mc2fn8Z7n2GDlgGS4a0vF1wrwuQsEOTMUZ4XWTOf0Q4xvaEqIyAq 7cL7NXPNdQoRR9JqB0vUzQbqiewEW23sd0S/FUif8QIpBBiTxtdAxlKSe aMLpe4OhzFnqtJz4SLzNfg7/b8BuRtX+2HTFvDaeb15rcVmOgFFrZrwtT oCA1I81u1mPqvUHn5M8uhXdZmd0iTp9glo5TRvyzn9YW3v/uidSXYrVOL w==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="369787791" X-IronPort-AV: E=Sophos;i="6.01,174,1684825200"; d="scan'208";a="369787791" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2023 08:50:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="848115459" X-IronPort-AV: E=Sophos;i="6.01,174,1684825200"; d="scan'208";a="848115459" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 15 Aug 2023 08:50:17 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qVwJD-00833p-2g; Tue, 15 Aug 2023 18:50:15 +0300 Date: Tue, 15 Aug 2023 18:50:15 +0300 From: Andy Shevchenko To: Dmitry Torokhov Cc: Wolfram Sang , Andi Shyti , Biju Das , Jonathan Cameron , Michael Hennerich , Peter Rosin , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 2/4] i2c: mux: ltc4306: convert to using a pointer in i2c_device_id Message-ID: References: <20230814-i2c-id-rework-v1-0-3e5bc71c49ee@gmail.com> <20230814-i2c-id-rework-v1-2-3e5bc71c49ee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230814-i2c-id-rework-v1-2-3e5bc71c49ee@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Mon, Aug 14, 2023 at 02:52:50PM -0700, Dmitry Torokhov wrote: > Switch the driver to use newly added "data" pointer in i2c_device_id to > streamline DT and legacy flows. ... > chip = of_device_get_match_data(&client->dev); > - > if (!chip) > - chip = &chips[i2c_match_id(ltc4306_id, client)->driver_data]; > + chip = i2c_match_id(ltc4306_id, client)->data; The whole thing can be converted to i2c_device_get_match_data() with the new helper from another thread. That said, I don't see value in this half-baked change. -- With Best Regards, Andy Shevchenko