From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Wolfram Sang <wsa@kernel.org>, Andi Shyti <andi.shyti@kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
Jonathan Cameron <jic23@kernel.org>,
Michael Hennerich <michael.hennerich@analog.com>,
Peter Rosin <peda@axentia.se>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 3/4] i2c: mux: pca954x: convert to using a pointer in i2c_device_id
Date: Tue, 15 Aug 2023 18:51:34 +0300 [thread overview]
Message-ID: <ZNufBsIT7KvEDA/c@smile.fi.intel.com> (raw)
In-Reply-To: <20230814-i2c-id-rework-v1-3-3e5bc71c49ee@gmail.com>
On Mon, Aug 14, 2023 at 02:52:51PM -0700, Dmitry Torokhov wrote:
> Switch the driver to use newly added "data" pointer in i2c_device_id to
> streamline DT and legacy flows.
...
> @@ -206,7 +206,7 @@ static const struct of_device_id pca954x_of_match[] = {
> { .compatible = "nxp,pca9847", .data = &chips[pca_9847] },
> { .compatible = "nxp,pca9848", .data = &chips[pca_9848] },
> { .compatible = "nxp,pca9849", .data = &chips[pca_9849] },
> - {}
> + { }
> };
> MODULE_DEVICE_TABLE(of, pca954x_of_match);
Stray change.
...
> data->chip = device_get_match_data(dev);
> if (!data->chip)
> - data->chip = &chips[id->driver_data];
> + data->chip = id->data;
Same, why not to use that helper and if anything, modify it instead.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-15 15:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 21:52 [PATCH RFC 0/4] Start unification of of_device_id and i2c_device_id Dmitry Torokhov
2023-08-14 21:52 ` [PATCH RFC 1/4] i2c: start migrating to a pointer in i2c_device_id Dmitry Torokhov
2023-08-15 15:55 ` Andy Shevchenko
2023-08-14 21:52 ` [PATCH RFC 2/4] i2c: mux: ltc4306: convert to using " Dmitry Torokhov
2023-08-15 15:50 ` Andy Shevchenko
2023-08-14 21:52 ` [PATCH RFC 3/4] i2c: mux: pca954x: " Dmitry Torokhov
2023-08-15 15:51 ` Andy Shevchenko [this message]
2023-08-14 21:52 ` [PATCH RFC 4/4] i2c: slave-eeprom: " Dmitry Torokhov
2023-08-15 15:53 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNufBsIT7KvEDA/c@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=peda@axentia.se \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox