From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF5DC71134 for ; Wed, 23 Aug 2023 19:02:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238266AbjHWTBy (ORCPT ); Wed, 23 Aug 2023 15:01:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238279AbjHWTBc (ORCPT ); Wed, 23 Aug 2023 15:01:32 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41AECE79; Wed, 23 Aug 2023 12:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692817290; x=1724353290; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=q8HqfOIX9FUQBqFQujvPJoo8ORZpfr5B1wEGzq2gXlY=; b=HisyjFpqQjib+Is/zE/Ogko/gDBh0DJLo5QncpDRlK8nFVnr84nfB2ZF Le1GceHLSyXMdejTIa+9f2Ccz/ATq6Q9TsOkDRRZrdXJYFAD+Z9cTvAZu O/tNtynzzRWyclDxIIVaxS8Lg+b6M+4ex/l/EtfaDKOObBOHxxIxgxbXl pKzKeQu9A3ts9KCvcYkILbhSA/ao9q0bBxHc2zi9cXYuO73mFfhDHJIBy Kyp9hmBG0PPhsVDrWhsLJKOi+PN5c1lmDQ/zHsDK7o1/sYETj3DeiSLGW /rRjsxgcEAaLVEu6PCLmW9NnGgCui/XHb++9Vg3PrN3RGEUU8xF4dsxQs A==; X-IronPort-AV: E=McAfee;i="6600,9927,10811"; a="364422883" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="364422883" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2023 12:01:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10811"; a="730324844" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="730324844" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2023 12:01:10 -0700 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with ESMTP id BCF7911F915; Wed, 23 Aug 2023 22:01:07 +0300 (EEST) Date: Wed, 23 Aug 2023 19:01:07 +0000 From: "sakari.ailus@linux.intel.com" To: "Wu, Wentong" Cc: Linus Walleij , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "mka@chromium.org" , "oneukum@suse.com" , "lee@kernel.org" , "wsa@kernel.org" , "kfting@nuvoton.com" , "broonie@kernel.org" , "maz@kernel.org" , "brgl@bgdev.pl" , "linux-usb@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "linux-spi@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "andriy.shevchenko@linux.intel.com" , "heikki.krogerus@linux.intel.com" , "andi.shyti@linux.intel.com" , "Pandruvada, Srinivas" , "linux-drivers-review@eclists.intel.com" , "Wang, Zhifeng" Subject: Re: [PATCH v9 4/4] gpio: update Intel LJCA USB GPIO driver Message-ID: References: <1692225111-19216-1-git-send-email-wentong.wu@intel.com> <1692225111-19216-5-git-send-email-wentong.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi Wentong, Linus, On Thu, Aug 17, 2023 at 07:07:54AM +0000, Wu, Wentong wrote: > > From: Linus Walleij > > > > On Thu, Aug 17, 2023 at 12:32 AM Wentong Wu > > wrote: > > > > > This driver communicate with LJCA GPIO module with specific protocol > > > through interfaces exported by LJCA USB driver. > > > Update the driver according to LJCA USB driver's changes. > > > > > > Signed-off-by: Wentong Wu > > > Reviewed-by: Sakari Ailus > > > > This patch does several things at the same time, consider the "one technical step > > per patch" approach, for some definition of a "technical step". The upside is that > > git bisect gets better precision when something goes sidewise. > > Ack, thanks. I will follow this going forward. The old LJCA GPIO driver got added without the rest of the LJCA, including the main driver (now 1st patch of this set). I might have just reverted the patch that added the old one and put the new one on top. The old driver was never usable AFAIU and there are many changes as Linus noted. It would be easier to review as new driver. I wonder what others think. -- Regards, Sakari Ailus