Re: [PATCH v2 1/2] i2c: wmt: split out i2c-viai2c-common.{c,h}

Hans Hu
2023-08-28T07:26:21Z

On 2023/8/28 14:00, Wolfram Sang wrote:
>> 1. I checked the MAINTAINERS section related to ARM/VT8500,
>> Found that the entire ARM/VT8500 ARCHITECTURE is currently
>> unmaintained, maybe one day it will be removed from the kernel.
>> So I think it might be better as a separate module.
> But even if we remove the arch, we will not remove the viai2c core,
> right? We just remove the Makefile entry for WMT. And your driver will
> still link two object files into one kernel object.
>
>> 2. In addition, if not separated from wmt, the driver would
>> become a bit confusing and difficult to maintain.
> Ah, maybe this is the misunderstanding. The seperation from WMT is very
> good! It is just that the new viai2c core shouldn't be a module itself
> but only a seperate object file which gets linked into your driver.
> Please check the octeon or pasemi driver for an example.
>

Sorry about the misunderstanding, will change to like below:

i2c-zhaoxin-objs:= i2c-viai2c-common.o i2c-zhaoxin-plt.o
obj-$(CONFIG_I2C_ZHAOXIN)       += i2c-zhaoxin.o
i2c-wmt-objs:= i2c-viai2c-common.o i2c-wmt-plt.o
obj-$(CONFIG_I2C_WMT)           += i2c-wmt.o

But I'm not sure which way is more appropriate:
change file name i2c-wmt.c to i2c-wmt-plt.c.(I prefer this)
or
change config name CONFIG_I2C_WMT to CONFIG_I2C_WMT_PLT.

Hans